TL/MLX5: add ctx option to disable a2a #1062
Open
+44
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
commented
Dec 30, 2024
| @@ -114,7 +114,8 @@ static ucc_config_field_t ucc_tl_mlx5_context_config_table[] = { | |||
| ucc_offsetof(ucc_tl_mlx5_context_config_t, devices), | |||
| UCC_CONFIG_TYPE_STRING_ARRAY}, | |||
|
|
|||
| {"MCAST_TIMEOUT", "10000", "Timeout [usec] for the reliability NACK in Mcast", | |||
| {"MCAST_TIMEOUT", "10000", | |||
| "Timeout [usec] for the reliability NACK in Mcast", | |||
There was a problem hiding this comment.
git-clang-format made this change
| @@ -269,7 +277,7 @@ ucc_status_t ucc_tl_mlx5_team_create_test(ucc_base_team_t *team) | |||
| } | |||
| } | |||
|
|
|||
| if (UCC_OK != a2a_status || UCC_OK != mcast_status) { | |||
| if (UCC_INPROGRESS == a2a_status || UCC_INPROGRESS == mcast_status) { | |||
There was a problem hiding this comment.
not directly related to the present PR but it seems like a bug
janjust
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option at the context level to disable tl/mlx5/a2a initialization
linked team task