TL/NCCL: lazy init nccl comm #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
force-pushed
the
topic/tl_nccl_lazy_init
branch
from
f21410e
to
2abc617
Compare
samnordmann
reviewed
Oct 11, 2023
Sergei-Lebedev
force-pushed
the
topic/tl_nccl_lazy_init
branch
from
2abc617
to
016c3db
Compare
samnordmann
approved these changes
Oct 15, 2023
bureddy
reviewed
Dec 6, 2023
Sergei-Lebedev
force-pushed
the
topic/tl_nccl_lazy_init
branch
from
016c3db
to
9d4d420
Compare
bureddy
approved these changes
Dec 15, 2023
Sergei-Lebedev
force-pushed
the
topic/tl_nccl_lazy_init
branch
from
9d4d420
to
c2aa99f
Compare
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* TL/NCCL: lazy init nccl comm * REVIEW: fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Lazily initialize TL NCCL on first CUDA collective.
Why ?
Both NCCL and CUDA require CUDA devices to be set before team create. In MPI workloads it's not always possible since MPI_Init creates UCC team and to set device we need to know rank and local rank.
replaces #758