check MCAST/A2A ctx/team ready #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
4 times, most recently
from
3f06198
to
64715f0
Compare
|
@samnordmann @Sergei-Lebedev this is a critical PR for the April release |
janjust
approved these changes
Mar 26, 2024
samnordmann
reviewed
Mar 26, 2024
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
from
64715f0
to
13168c3
Compare
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
from
13168c3
to
6cda6a7
Compare
|
@janjust @samnordmann Thank you guys for the reviews. I have resolved/answered them. Please let me know if you have more comments. |
samnordmann
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Thanks!
Can you please ask for a new review through github by clicking "Re-request review"? This would help me. Also, please do not resolve my comments/questions that are not fixed, or that I will probably need to check again, so it will be easier for me to keep track
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
from
6cda6a7
to
33a06ba
Compare
samnordmann
reviewed
Apr 2, 2024
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
from
33a06ba
to
19db70c
Compare
|
@samnordmann Thanks for the new comments. I pushed the new changes. Please take a look. |
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
from
19db70c
to
50bea90
Compare
MamziB
force-pushed
the
mamzi/mcast-merge-11
branch
from
50bea90
to
1cf16d1
Compare
|
@Sergei-Lebedev Thanks for the comment. I have resolved them and I updated the commit. |
Sergei-Lebedev
approved these changes
Apr 8, 2024
Sergei-Lebedev
force-pushed
the
mamzi/mcast-merge-11
branch
from
1cf16d1
to
7a748ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check MCAST/A2A ctx/team ready before creating mlx5 teams and also check after mlx5 team creation to make sure every process created mcast/a2a team successfully