-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL/CUDA: Linear Broadcast for GPU #948
base: master
Are you sure you want to change the base?
Conversation
Configuration string: |
Can one of the admins verify this patch? |
00f3922
to
6caea67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
I only left some minor remarks. Can you, in addition, add this algo to the tests?
Thanks for review, addressed comments and added test to validate bcast for cuda too. |
What
Linear CUDA Broadcast implementation.
Why ?
How ?
Naive approach where root rank writes data to own shared buffer and others ranks read from it through NVLink.