BUILD: add support for specific gpu ach with ROCM #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@akolliasAMD Please also get review from @edgargabriel |
akolliasAMD
force-pushed
the
topic/amdclang-arch-param
branch
from
d69f536
to
ada82be
Compare
@manjugv this looks good to me. I don't think the repo allows me to do a formal review, but we discussed this with @akolliasAMD internally before he filed the PR. |
edgargabriel
approved these changes
Jun 12, 2024
samnordmann
approved these changes
Jun 12, 2024
akolliasAMD
force-pushed
the
topic/amdclang-arch-param
branch
from
ada82be
to
7db54d7
Compare
akolliasAMD
changed the title
|
Can you give it another thumbs up for the CI to continue? EDIT: Actually will do a proper rebase and repush sorry |
akolliasAMD
force-pushed
the
topic/amdclang-arch-param
branch
from
71f07f4
to
feb4712
Compare
|
ok to test |
akolliasAMD
force-pushed
the
topic/amdclang-arch-param
branch
2 times, most recently
from
b28c8ca
to
69f9647
Compare
Sergei-Lebedev
approved these changes
Jun 16, 2024
samnordmann
approved these changes
Jun 17, 2024
|
Do you want me to just rebase from master and merge? |
yes please |
akolliasAMD
force-pushed
the
topic/amdclang-arch-param
branch
from
69f9647
to
32c944b
Compare
|
ok rebased. Will wait for tests to pass and merge hopefully |
|
jenkins error is unrelated |
MamziB
pushed a commit
to MamziB/ucc-forked
that referenced
this pull request
Jun 25, 2024
MamziB
pushed a commit
to MamziB/ucc-forked
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added ability to specify ROCM architecture on configure with --with-rocm-arch
options are:
allwhich does the same behavior as before,all-arch-no-nativedoes all default rocm architectures with the exception of native (to be used if no rocm enabled gpus exist in the system)--offload-arch=gfx###for specifying a specific architectureWhy ?
This allows specifying a specific architecture. It will fix the #969 issue