TL/MLX5: adding mcast allgather staging based algo #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MamziB
requested review from
samnordmann and
Sergei-Lebedev
and removed request for
samnordmann
samnordmann
reviewed
Jul 1, 2024
|
The CI has relevant issues |
|
Hi @samnordmann Thanks for the constructive comments. I have addressed those and added a new commit (second commit). Please take a look and let me know your thoughts. |
samnordmann
reviewed
Jul 2, 2024
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_progress.c
Outdated
Show resolved
Hide resolved
samnordmann
reviewed
Jul 2, 2024
MamziB
commented
Jul 3, 2024
|
Thanks @samnordmann for today's comments. I have added a new separate commit. Please take a look. Also, I have yet to cut something from this PR to make it shorter. |
samnordmann
approved these changes
Jul 3, 2024
|
#994 (comment) |
MamziB
force-pushed
the
mamzi/mcast-allgather-3-part-1
branch
from
711f798
to
61b99b6
Compare
MamziB
force-pushed
the
mamzi/mcast-allgather-3-part-1
branch
from
13e6845
to
75576ee
Compare
|
Thank you Sergey and Sam. All the comments have been resolved. |
|
@ Sergei-Lebedev can you also look at this PR and let me know if you have more comments? Thank you, Sergey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add the algorithm for mcast-based allgather
Why
scalability and performance improvement over sw based allgather
How ?
Realizing the Allgather operations as N (team-size) concurrent Bcast operations (every process becomes the root). We use the one-sided design that was merged before for its reliability.