-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL/MLX5: adding mcast allgather staging based algo #994
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have time to review everything yet, but here is a first quick round of review. I see several natural ways to make the PR smaller -- more than 1k lines is a large pr, so please try to break it down whenever possible.
The CI has relevant issues |
Hi @samnordmann Thanks for the constructive comments. I have addressed those and added a new commit (second commit). Please take a look and let me know your thoughts. |
src/components/tl/mlx5/mcast/tl_mlx5_mcast_one_sided_progress.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the comment! Here is another round
Thanks @samnordmann for today's comments. I have added a new separate commit. Please take a look. Also, I have yet to cut something from this PR to make it shorter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the comments
#994 (comment) |
711f798
to
61b99b6
Compare
13e6845
to
75576ee
Compare
Thank you Sergey and Sam. All the comments have been resolved. |
@ Sergei-Lebedev can you also look at this PR and let me know if you have more comments? Thank you, Sergey! |
What
add the algorithm for mcast-based allgather
Why
scalability and performance improvement over sw based allgather
How ?
Realizing the Allgather operations as N (team-size) concurrent Bcast operations (every process becomes the root). We use the one-sided design that was merged before for its reliability.