refactor: extract and rename function

Rename the parseName function to splitPackageName to better reflect it's purpose. Also moved to separate module

lib/cmd-add.ts

@@ -9,10 +9,10 @@ import {
   loadManifest,
   parseEditorVersion,
   parseEnv,
-  parseName,
   saveManifest,
 } from "./core";
 import { isUrlVersion } from "./utils/pkg-version";
+import { splitPackageName } from "./utils/pkg-name";
 
 export type AddOptions = {
   test: boolean;
@@ -58,9 +58,9 @@ const _add = async function ({
   // is upstream package flag
   let isUpstreamPackage = false;
   // parse name
-  const parseResult = parseName(pkg);
-  const name = parseResult.name;
-  let version = parseResult.version;
+  const split = splitPackageName(pkg);
+  const name = split.name;
+  let version = split.version;
 
   // load manifest
   const manifest = loadManifest();

lib/cmd-deps.ts

@@ -1,5 +1,6 @@
 import log from "./logger";
-import { fetchPackageDependencies, parseEnv, parseName } from "./core";
+import { fetchPackageDependencies, parseEnv } from "./core";
+import { splitPackageName } from "./utils/pkg-name";
 
 export type DepsOptions = {
   deep: boolean;
@@ -11,7 +12,7 @@ export const deps = async function (pkg: PkgName, options: DepsOptions) {
   const envOk = await parseEnv(options, { checkPath: false });
   if (!envOk) return 1;
   // parse name
-  const { name, version } = parseName(pkg);
+  const { name, version } = splitPackageName(pkg);
   // deps
   await _deps({ name, version, deep: options.deep });
   return 0;

lib/cmd-remove.ts

@@ -1,5 +1,6 @@
 import log from "./logger";
-import { env, loadManifest, parseEnv, parseName, saveManifest } from "./core";
+import { env, loadManifest, parseEnv, saveManifest } from "./core";
+import { splitPackageName } from "./utils/pkg-name";
 
 export type RemoveOptions = {
   _global: GlobalOptions;
@@ -30,9 +31,9 @@ const _remove = async function (pkg: PkgName) {
   // dirty flag
   let dirty = false;
   // parse name
-  const parseResult = parseName(pkg);
-  const name = parseResult.name;
-  let version = parseResult.version;
+  const split = splitPackageName(pkg);
+  const name = split.name;
+  let version = split.version;
   if (version) {
     log.warn("", `please replace '${name}@${version}' with '${name}'`);
     return { code: 1, dirty };

lib/cmd-view.ts

@@ -1,13 +1,8 @@
 import chalk from "chalk";
 import log from "./logger";
-import {
-  env,
-  fetchPackageInfo,
-  getLatestVersion,
-  parseEnv,
-  parseName,
-} from "./core";
+import { env, fetchPackageInfo, getLatestVersion, parseEnv } from "./core";
 import assert from "assert";
+import { splitPackageName } from "./utils/pkg-name";
 
 export type ViewOptions = {
   _global: GlobalOptions;
@@ -18,7 +13,7 @@ export const view = async function (pkg: PkgName, options: ViewOptions) {
   const envOk = await parseEnv(options, { checkPath: false });
   if (!envOk) return 1;
   // parse name
-  const { name, version } = parseName(pkg);
+  const { name, version } = splitPackageName(pkg);
   if (version) {
     log.warn("", `please replace '${name}@${version}' with '${name}'`);
     return 1;

lib/core.ts

@@ -156,18 +156,6 @@ export const parseEnv = async function (
   return true;
 };
 
-// Parse name to {name, version}
-export const parseName = function (pkg: PkgName): {
-  name: ReverseDomainName;
-  version: PkgVersion | undefined;
-} {
-  const segs = pkg.split("@");
-  const name = segs[0];
-  const version =
-    segs.length > 1 ? segs.slice(1, segs.length).join("@") : undefined;
-  return { name, version };
-};
-
 // Get npm fetch options
 export const getNpmFetchOptions = function (): search.Options {
   const opts: search.Options = {

lib/utils/pkg-name.ts

@@ -0,0 +1,16 @@
+/**
+ * Split package-name, which may include a version into the actual name of the
+ * package and the version if it exists
+ */
+export const splitPackageName = function (pkgName: PkgName): {
+  name: ReverseDomainName;
+  version: PkgVersion | undefined;
+} {
+  const segments = pkgName.split("@");
+  const name = segments[0];
+  const version =
+    segments.length > 1
+      ? segments.slice(1, segments.length).join("@")
+      : undefined;
+  return { name, version };
+};