refactor: simplify defined assertions

openupm · Nov 16, 2023 · 3ef76de · 3ef76de
1 parent 63f94ce
commit 3ef76de
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 17 deletions.
diff --git a/test/test-cmd-add.ts b/test/test-cmd-add.ts
@@ -1,4 +1,3 @@
-import "assert";
 import "should";
 import { add, AddOptions } from "../src/cmd-add";
 import { PkgInfo, PkgManifest } from "../src/types/global";

diff --git a/test/test-cmd-deps.ts b/test/test-cmd-deps.ts
@@ -1,8 +1,5 @@
-import "assert";
 import "should";
-
 import { deps, DepsOptions } from "../src/cmd-deps";
-
 import {
   exampleRegistryUrl,
   registerMissingPackage,

diff --git a/test/test-cmd-login.ts b/test/test-cmd-login.ts
@@ -1,4 +1,3 @@
-import "assert";
 import "nock";
 import should from "should";
 import {

diff --git a/test/test-cmd-remove.ts b/test/test-cmd-remove.ts
@@ -1,4 +1,3 @@
-import "assert";
 import "should";
 import { remove } from "../src/cmd-remove";
 import { PkgManifest } from "../src/types/global";

diff --git a/test/test-cmd-search.ts b/test/test-cmd-search.ts
@@ -1,4 +1,3 @@
-import "assert";
 import nock from "nock";
 import "should";
 import { search, SearchOptions } from "../src/cmd-search";

diff --git a/test/test-cmd-view.ts b/test/test-cmd-view.ts
@@ -1,4 +1,3 @@
-import "assert";
 import "should";
 import { view, ViewOptions } from "../src/cmd-view";
 import { PkgInfo } from "../src/types/global";

diff --git a/test/test-env.ts b/test/test-env.ts
@@ -1,9 +1,9 @@
 import "should";
 import { env, parseEnv } from "../src/utils/env";
 import path from "path";
-import assert from "assert";
 import { createWorkDir, getWorkDir, removeWorkDir } from "./mock-work-dir";
 import { attachMockConsole, MockConsole } from "./mock-console";
+import should from "should";
 
 describe("env", function () {
   describe("parseEnv", function () {
@@ -157,8 +157,7 @@ describe("env", function () {
           { checkPath: true }
         )
       ).should.be.ok();
-      assert(env.editorVersion !== null);
-      env.editorVersion.should.be.equal("2019.2.13f1");
+      should(env.editorVersion).be.equal("2019.2.13f1");
     });
     it("region cn", async function () {
       (

diff --git a/test/test-pgk-info.ts b/test/test-pgk-info.ts
@@ -1,14 +1,13 @@
 import { tryGetLatestVersion } from "../src/utils/pkg-info";
-import assert from "assert";
 import "should";
 import { describe } from "mocha";
+import should from "should";
 
 describe("pkg-info", function () {
   describe("tryGetLatestVersion", function () {
     it("from dist-tags", async function () {
       const version = tryGetLatestVersion({ "dist-tags": { latest: "1.0.0" } });
-      assert(version !== undefined);
-      version.should.equal("1.0.0");
+      should(version).equal("1.0.0");
     });
   });
 });
diff --git a/test/test-registry-client.ts b/test/test-registry-client.ts
@@ -1,6 +1,5 @@
 import "assert";
 import "should";
-import assert from "assert";
 import { parseEnv } from "../src/utils/env";
 import { fetchPackageInfo } from "../src/registry-client";
 import { PkgInfo } from "../src/types/global";
@@ -11,6 +10,7 @@ import {
   startMockRegistry,
   stopMockRegistry,
 } from "./mock-registry";
+import should from "should";
 
 describe("registry-client", function () {
   describe("fetchPackageInfo", function () {
@@ -34,8 +34,7 @@ describe("registry-client", function () {
       };
       registerRemotePkg(pkgInfoRemote);
       const info = await fetchPackageInfo("package-a");
-      assert(info !== undefined);
-      info.should.deepEqual(pkgInfoRemote);
+      should(info).deepEqual(pkgInfoRemote);
     });
     it("404", async function () {
       (