refactor: undefined to null

Replace undefined with null in argument for makePackageReference function since it is an intentionally missing value
openupm · Sep 29, 2024 · 474464a · 474464a
1 parent 2d856be
commit 474464a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/domain/package-reference.ts b/src/domain/package-reference.ts
@@ -76,14 +76,15 @@ export function splitPackageReference(
  */
 export function makePackageReference(
   name: string,
-  version?: string
+  version: string | null
 ): PackageReference {
   assertZod(name, DomainName);
+  if (version === null) return name;
   assert(
-    version === undefined || isVersionReference(version),
-    `"${version}" is valid version-reference`
+    isVersionReference(version),
+    `"${version}" is not a valid version reference.`
   );
-  return version !== undefined ? `${name}@${version}` : name;
+  return `${name}@${version}`;
 }
 
 /**

diff --git a/test/unit/domain/package-reference.test.ts b/test/unit/domain/package-reference.test.ts
@@ -80,7 +80,7 @@ describe("package-reference", () => {
   describe("split", () => {
     function shouldSplitCorrectly(name: string, version?: string) {
       const [actualName, actualVersion] = splitPackageReference(
-        makePackageReference(name, version)
+        makePackageReference(name, version ?? null)
       );
       expect(actualName).toEqual(name);
       expect(actualVersion).toEqual(version ?? null);