fix: handle null

Throw if editor-version could not be parsed
openupm · Oct 24, 2023 · dd0cc5c · dd0cc5c
1 parent 9108970
commit dd0cc5c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/core.ts b/lib/core.ts
@@ -434,6 +434,10 @@ export const saveUpmConfig = async function (
 export const compareEditorVersion = function (a: string, b: string) {
   const verA = parseEditorVersion(a);
   const verB = parseEditorVersion(b);
+
+  if (verA === null || verB === null)
+    throw new Error("An editor version could not be parsed");
+
   const editorVersionToArray = (ver: SemanticVersion) => [
     ver.major,
     ver.minor,
@@ -443,10 +447,7 @@ export const compareEditorVersion = function (a: string, b: string) {
     ver.locValue || 0,
     ver.locBuild || 0,
   ];
-  // TODO: Handle null
-  // @ts-ignore
   const arrA = editorVersionToArray(verA);
-  // @ts-ignore
   const arrB = editorVersionToArray(verB);
   for (let i = 0; i < arrA.length; i++) {
     const valA = arrA[i];