merge wip to main #403
Merged
merge wip to main #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are tests for a impure function which basically just wraps an external library. Not really any domain logic going on, so nothing to test really
Currently we use `another-npm-registry-client` for fetching packuments. This is a fork of a deprecated library. This change instead uses the currently maintained library for fetching packuments that is maintained by npm Just to modernize the dependencies a bit.
`another-npm-registry-client` is a fork of `npm-registry-client` which is a, now deprecated, library for interacting with npm registries. At this point, the project does not use any runtime code from the library (see 893a67e and a678e14). The only part of it we still used was the NpmAuth type which represents npm authentication data. But there is already a type for this as part of the `npm-registry-fetch` libary. Therefore the dependency can now safely be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.