feat: basic cli-argument validation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syntax is necessary in order to specify parsing functions in a future commit
As far as I can tell this "registry" option is not used. The login function seems to use the global registry option.
favoyang
approved these changes
Dec 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
# [1.19.0](1.18.1...1.19.0) (2023-12-21) ### Features * basic cli-argument validation ([#72](#72)) ([49d0a96](49d0a96))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects
This introduces checks, such as making sure, that when calling
openupm addthe package argument is a valid package name.This PR does not include any new tests. It would be nice to be able to test the app on the cli level, but further refactors are necessary for that.