Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use default version of gcc on Ubuntu VM #5452

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Mar 20, 2024

asan is failing a lot (and seems random).

Well, it is probably not a good idea to use gcc-13 + ASAN on Ubuntu-latest (the default gcc is 11).


It looks better now, using the PR, but we can't be sure without more random testing.

@claudioandre-br
Copy link
Member Author

CI is clean. Forcing another run for testing.

The previously specified combo version may not be in the best shape.

Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
@solardiz
Copy link
Member

asan is failing a lot (and seems random).

My guess was that we simply exceeded some kind of GitHub Actions resources for our org, with my recent multiple quick pushes to bleeding-jumbo, which resulted in several sets of CI jobs running concurrently. I've since rerun the failed jobs on a couple of commits, and they all succeeded.

I think it made sense for us to use newer gcc's ASan, but I also don't mind your changes here. So I'll merge.

@solardiz solardiz merged commit 76cc114 into openwall:bleeding-jumbo Mar 20, 2024
31 checks passed
@claudioandre-br
Copy link
Member Author

My guess was that we simply exceeded some kind of GitHub Actions resources for our org,

I saw this ASAN AddressSanitizer:DEADLYSIGNAL error a week ago [1] (and nothing was running). But since it's random, I can't say much about it.

The org in the situation was me.

[1] https://github.com/claudioandre-br/JohnTheRipper/actions/runs/8248714971 versus, e.g., https://github.com/openwall/john/actions/runs/8351346753/job/22859525043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants