Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: various updates #8

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 9, 2024

  1. Start running tests against PHP 8.4 (expected to be released end of November).
  2. Update the actions/checkout action runner.
  3. Update the ramsey/composer-install action runner.
  4. Fix an outdated link.

1. Start running tests against PHP 8.4 (expected to be released end of November).
2. Update the `actions/checkout` action runner.
3. Update the `ramsey/composer-install` action runner.
4. Fix an outdated link.
@jrfnl jrfnl force-pushed the feature/ghactions-various-updates branch 2 times, most recently from ed8c7c2 to c4ec1a8 Compare September 9, 2024 18:59
@solardiz solardiz merged commit 95c8c1d into openwall:main Sep 10, 2024
28 checks passed
@solardiz
Copy link
Member

Thank you very much, @jrfnl!

Is it normal that under Unit Test we're getting the below numbers? -

OK, but there were issues!
Tests: 6, Assertions: 6, PHPUnit Deprecations: 3.

Specifically, what does Assertions: 6 mean? Are these passed or failed assertions?

@jrfnl jrfnl deleted the feature/ghactions-various-updates branch September 10, 2024 20:56
@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 10, 2024

Is it normal that under Unit Test we're getting the below numbers? -

OK, but there were issues!
Tests: 6, Assertions: 6, PHPUnit Deprecations: 3.

Specifically, what does Assertions: 6 mean? Are these passed or failed assertions?

Hi @solardiz, yes, what you showed is the test summary. This will always show the total number of test methods run + the total number of assertions run (one test method may contain multiple assertions, so tests will normally be equal to or lower than the assertions count.

Depending on the PHPUnit version, various other counters could show (depending on tests and status):

  • A failure counter - this will only show if there were any failed tests/assertions.
  • An error counter - these are typically tests which did not run/finish due to a PHP error during execution.
  • A warning counter - similar for warnings, though depending on the PHPUnit version, this may mean the test(s) will have continued running.
  • A deprecation counter - similar for PHP deprecations, though depending on the PHPUnit version, this may mean the test(s) will have continued running.
  • And then there is the new "PHPUnit Warnings" and "PHPUnit Deprecations", which will show counters of the number of PHPUnit related warnings and deprecations. The warnings will normally show as well in the output and will have to be handled. The PHPUnit deprecations can be ignored until the test suite wants to allow next major version of PHPUnit.

Does that help ?

Generally speaking, if all tests pass, PHPUnit will have a 0 exit code, if there are errors or failing tests, the exit code will be 1. For the other items, whether these influence the exit code is configurable, but by default, they shouldn't influence the exit code.

Looking at the current summary, let me fix those deprecations and get the tests running on PHPUnit 11 too (released Feb 2024).

@solardiz
Copy link
Member

Does that help ?

It certainly does. Too much detail for right now (as I'm busy with other projects), but a helpful reference for later. Thank you!

let me fix those deprecations and get the tests running on PHPUnit 11 too (released Feb 2024).

I guess this means another PR from you soon. :-)

@jrfnl
Copy link
Contributor Author

jrfnl commented Sep 12, 2024

let me fix those deprecations and get the tests running on PHPUnit 11 too (released Feb 2024).

I guess this means another PR from you soon. :-)

Indeed. PR #9 actions the first part ("fix those deprecations").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants