Skip to content

Commit

Permalink
bugfix: fix drpc response to permit empty lists or objects
Browse files Browse the repository at this point in the history
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
  • Loading branch information
amanji committed Feb 20, 2024
1 parent 1eba9a0 commit 347e8c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion rpc/rpc/v1_0/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ async def handle(self, context: RequestContext, responder: BaseResponder):
response_record = await DRPCRecord.retrieve_by_connection_and_thread(
session, connection_id, thread_id
)
response_record.response = context.message.response.serialize()
response_record.response = context.message.response
response_record.state = DRPCRecord.STATE_COMPLETED
serialized_response_record = response_record.serialize()

Expand Down
4 changes: 2 additions & 2 deletions rpc/rpc/v1_0/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ class Response(fields.Field):
def load_response_or_error(self, value):
"""Load RPC response or error."""

return RPCResponseModelSchema().load(value) if value else None
return RPCResponseModelSchema().load(value) if value != None else None

def dump_response_or_error(self, value):
"""Dump RPC response or error."""

return RPCResponseModelSchema().dump(value) if value else None
return RPCResponseModelSchema().dump(value) if value != None else None

def _serialize(self, value, attr, obj, **kwargs):
"""Serialize RPC response or error."""
Expand Down

0 comments on commit 347e8c0

Please sign in to comment.