Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainers should include Poetry version 1.6.1 (or 1.7.1?) #84

Closed
loneil opened this issue Feb 1, 2024 · 3 comments
Closed

Devcontainers should include Poetry version 1.6.1 (or 1.7.1?) #84

loneil opened this issue Feb 1, 2024 · 3 comments

Comments

@loneil
Copy link
Contributor

loneil commented Feb 1, 2024

The ACA-Py libraries are built with 1.6.1
https://github.com/hyperledger/aries-cloudagent-python/blob/main/poetry.lock

so probably want to stay in sync for this repo's Poetry usage in the devcontainer? Currently "POETRY_VERSION": "1.4.2"
https://github.com/hyperledger/aries-acapy-plugins/tree/main/plugin_globals/.devcontainer

@loneil
Copy link
Contributor Author

loneil commented Feb 1, 2024

Each individual plugin seems to have been generated on 1.7.1 though. But the devcontainer definitions say 1.4.2 as well

@loneil loneil changed the title Devcontainer should include Poetry version 1.6.1 Devcontainers should include Poetry version 1.6.1 (or 1.7.1?) Feb 2, 2024
@jamshale
Copy link
Contributor

jamshale commented Feb 2, 2024

I ran the script locally that's why it's 1.7.1. Dev containers should be updated ✔️

@loneil
Copy link
Contributor Author

loneil commented Feb 2, 2024

Ok thanks. I did a PR to update them here. Found 1.4.2 references in dockerfiles too
#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants