Normalize poetry versions in devcontainers/docker to match lockfiles #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
|
Issue #84 |
jamshale
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
poetry.lockfiles have been generated by 1.7.1 for the plugins, but looks like the devcontainers and dokerfiles reference Poetry 1.4.2.This PR sets them all to the matching 1.7.1
ACA-Py actually uses 1.6.1 so maybe that would be more appropriate, but ACA-Py should probably update to a newer version with 0.12.0 (?) or a subsequent release. Also it probably doesn't matter to have the slight mismatch between these plugins and ACA-Py for Poetry version
https://github.com/hyperledger/aries-cloudagent-python/blob/main/poetry.lock