Multitenancy Support for OID4VC Plugin #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pradeep Kumar Prakasam <pradeep.prakasam@ontario.ca>
|
Tagging @mepeltier in for a first round of reviews. Thanks @pradeepp88! |
Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
|
Some fixes have been added here: pradeepp88#1 |
…upport OID4VC Multitenancy Fixes and Demo Changes
|
@pradeepp88 I know you're planning on presenting to the ACA-PUG here soon, but in the meantime, is there anything else that's needed here? Anything we can help with? |
Signed-off-by: Pradeep Kumar Prakasam <pradeep.prakasam@ontario.ca>
pradeepp88
force-pushed
the
feature/oid4vc-multitenancy-support
branch
from
269fef2 to
2ff7707
Compare
|
@mepeltier - I have updated the unit tests for the public routes to ensure all tests pass without modifying the As discussed, I will provide a demo during tomorrow's meeting. Please review the changes and share your feedback. |
dbluhm
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multitenancy Support for OID4VC Plugin
This PR closes #1161.
Summary of Proposed changes to Support Multitenancy:
Multitenant Support in
oid4vci_server.pywallet_idis provided in the request, the wallet profile is retrieved and injected into the context using thecontext.inject_or(BaseMultitenantManager).wallet_keyis available in the wallet record of theroot_profile. It is used along with thewallet_idto extract the wallet profile, which is then injected into the metadata. This logic is consistent with the approach currently used by theacapy_agentadmin server to extract the profile from the authentication token.Subpath Addition in
public_routes.py/tenant/{wallet_id}withwallet_idas a path parameter for all public routes when multitenancy is enabled. Otherwise, the routes remain unchanged.Updates to
credentials_issuer_metadataEndpointcredentials_issuer_metadataendpoint inpublic_routes.pyto reflect the multitenancy changes.Updates to
get_cred_offerEndpointget_cred_offerendpoint inroutes.pyto support the multitenancy updates.Note:
These changes aim to enable multitenancy in the OID4VC plugin with minimal modifications. Feedback from the community on this proposed design would be greatly appreciated.