Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add firebase push notification plugin #175

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Add firebase push notification plugin #175

merged 8 commits into from
Mar 18, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Feb 27, 2024 •
edited
Loading

Adds the firebase push notification plugin with documentation, unit test and configurations.

Note: Integration tests not completed. Quite involved, as it requires setting up a mediated connection and a dummy webhook server to make sure events are being triggered and attempting to contact firebase server. Will create another ticket for this task.

@jamshale jamshale marked this pull request as ready for review March 1, 2024 18:57
@jamshale jamshale requested review from esune and amanji March 1, 2024 18:57
amanji
amanji reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@amanji amanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. I've added some very minor comments that I leave to your discretion whether they need to be addressed or not.

esune
esune reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall. Just a comment about log levels: with high load printing a high volume of statements to console might cause performance issues, and make the service very verbose - unsure on whether we want that by design or not.

firebase_push_notifications/firebase_push_notifications/v1_0/manager.py Outdated Show resolved Hide resolved
firebase_push_notifications/firebase_push_notifications/v1_0/manager.py Outdated Show resolved Hide resolved
@jamshale
Copy link
Contributor Author

jamshale commented Mar 6, 2024

Updated to address comments and change logging.

esune
esune approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@jamshale
Copy link
Contributor Author

jamshale commented Mar 18, 2024 •
edited
Loading

@amanji Could you approve this or update any comments? I need a maintainer approval to merge.

amanji
amanji approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@amanji amanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far!

jamshale added 8 commits March 18, 2024 14:45
@jamshale
Add firebase push notification plugin
103fd4c 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
poetry install integration test dir
5b2dc96 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Refactor based on comments
6a3715f 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Adjust mermaid doc
c425134 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Fix linting error
f48e90d 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Update firebase_push_notifications
1ac8ead 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Fix unit test for removed log
06672b9 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Rename firebase swagger api routes
1031aab 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale merged commit 8197d6e into openwallet-foundation:main Mar 18, 2024
3 checks passed
ff137 referenced this pull request in didx-xyz/aries-acapy-plugins Apr 11, 2024
@ff137 @jamshale
@dependabot @dbluhm
♻️ Synchronise with upstream (#134)
41f9e57 
* Upgrades (#228)

* Change plugin_globals dev deps specifications

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* Update basicmessage_storage

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* Upgrade connection_update

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* Update kafka_events

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* update multitenant provider

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* Upgrade rpc

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* update oid4vci

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* update redis_events

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* fix test

Signed-off-by: jamshale <jamiehalebc@gmail.com>

---------

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* chore(deps): Bump follow-redirects in /oid4vci/demo/frontend (#270)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add firebase push notification plugin (#175)

* Add firebase push notification plugin

Signed-off-by: jamshale <jamiehalebc@gmail.com>


---------

Signed-off-by: jamshale <jamiehalebc@gmail.com>

* chore(deps): Bump the all-actions group with 1 update (#315)

Bumps the all-actions group with 1 update: [tj-actions/changed-files](https://github.com/tj-actions/changed-files).


Updates `tj-actions/changed-files` from 42 to 44
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v42...v44)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump pillow in /firebase_push_notifications

Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to 10.3.0.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@10.2.0...10.3.0)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: enable merge group for checks

To get a handle on the dependabot PRs open on this repo, I'm
experimenting with introducing a merge queue. This change will enable
the merge queue to know which checks to run to make sure a branch is
ready to merge.

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>

* chore(deps): Bump tar from 6.2.0 to 6.2.1 in /oid4vci/integration/afj

Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.2.0...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Bluhm <dbluhm@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanji amanji amanji approved these changes

@esune esune esune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamshale @esune @amanji