Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to push workflow #20

Merged

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Oct 30, 2023

This will run unit tests and lint checking in their own workflow and only for plugins that have changes. It has been changed to only run on PR's and push to main.

@jamshale jamshale force-pushed the feat/16-run-unit-tests-on-push branch from c0e3eca to 051418b Compare October 30, 2023 20:01
@dbluhm
Copy link
Contributor

dbluhm commented Nov 8, 2023

Do we really want to run unit tests whenever there's a push to any branch? I can see main and running them on PRs of course but running them on every push feels unnecessary.

@jamshale
Copy link
Contributor Author

jamshale commented Nov 8, 2023

@dbluhm Ya. I agree. I was thinking because it is already installing the deps to do the linting that it wouldn't be that much extra. I'm going to move both this and the linting jobs to the PR action.

@jamshale
Copy link
Contributor Author

jamshale commented Nov 8, 2023

I think I'll wait until I get the integration test PR finished and then move these tests to that action to only run on changes as well.

@jamshale jamshale marked this pull request as draft November 10, 2023 19:07
@jamshale jamshale force-pushed the feat/16-run-unit-tests-on-push branch from 051418b to 5adcae6 Compare November 10, 2023 19:26
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale force-pushed the feat/16-run-unit-tests-on-push branch from fdb2da3 to 38e20ae Compare November 10, 2023 21:41
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale force-pushed the feat/16-run-unit-tests-on-push branch from 38019ed to eb2194a Compare November 10, 2023 23:21
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale force-pushed the feat/16-run-unit-tests-on-push branch from 838b9ea to 4bf1795 Compare November 11, 2023 01:35
@jamshale jamshale marked this pull request as ready for review November 14, 2023 20:07
@jamshale
Copy link
Contributor Author

This has been updated.

There was problems with the redis_events testing. I needed to change the integration tests to become an internal network and the pytests weren't locating the plugin root. The easiest way to fix this was to change the sys.path for the pytest init file.

@jamshale jamshale requested a review from dbluhm November 14, 2023 21:19
@jamshale jamshale merged commit 4a547ed into openwallet-foundation:main Nov 15, 2023
7 checks passed
@jamshale jamshale deleted the feat/16-run-unit-tests-on-push branch April 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants