-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests to push workflow #20
Add unit tests to push workflow #20
Conversation
c0e3eca
to
051418b
Compare
Do we really want to run unit tests whenever there's a push to any branch? I can see main and running them on PRs of course but running them on every push feels unnecessary. |
@dbluhm Ya. I agree. I was thinking because it is already installing the deps to do the linting that it wouldn't be that much extra. I'm going to move both this and the linting jobs to the PR action. |
I think I'll wait until I get the integration test PR finished and then move these tests to that action to only run on changes as well. |
051418b
to
5adcae6
Compare
Signed-off-by: jamshale <jamiehalebc@gmail.com>
fdb2da3
to
38e20ae
Compare
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
38019ed
to
eb2194a
Compare
Signed-off-by: jamshale <jamiehalebc@gmail.com>
838b9ea
to
4bf1795
Compare
This has been updated. There was problems with the redis_events testing. I needed to change the integration tests to become an internal network and the pytests weren't locating the plugin root. The easiest way to fix this was to change the sys.path for the pytest init file. |
This will run unit tests and lint checking in their own workflow and only for plugins that have changes. It has been changed to only run on PR's and push to main.