Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflows #418

Merged
merged 19 commits into from
May 7, 2024
Merged

Release workflows #418

merged 19 commits into from
May 7, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented May 2, 2024

Opening this as a new PR again. I had to do work on my forked main branch and when I rebased it forced closed the old PR's.
#391
#387

I think I addressed all the comments.

Some of the bash scripting is pretty gross but I tried to comment and document it well.

I had to fix some tests and I upgraded the anoncreds library as well. This is where the changes unrelated to the workflows came from.

jamshale and others added 17 commits April 22, 2024 11:03
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Fix wallet type in multitenant integration tests
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale marked this pull request as ready for review May 3, 2024 15:43
@jamshale jamshale requested a review from WadeBarnes May 6, 2024 15:56
Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one question below, the workflows look good from a high level. I did not review the code in the various steps in detail.

oid4vci/integration/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale merged commit d957b01 into openwallet-foundation:main May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants