OID4VCI plugin - Fix delete exchange-supported records #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
approved these changes
May 15, 2024
|
You'll need to sign your commits. Then we can merge this. |
I, timbl-ont <tim.bloomfield@ontario.ca>, hereby add my Signed-off-by to this commit: c338c50 Signed-off-by: timbl-ont <tim.bloomfield@ontario.ca>
|
@jamshale DCO has been added. |
|
The DCO check is still broken. There's info here on how to repair it. https://github.com/hyperledger/aries-acapy-plugins/pull/460/checks?check_run_id=25285335698. You can do the rebase method if you want. I think it's the simplest. |
I, timbl-ont <tim.bloomfield@ontario.ca>, hereby add my Signed-off-by to this commit: c338c50 Signed-off-by: timbl-ont <tim.bloomfield@ontario.ca>
I, timbl-ont <tim.bloomfield@ontario.ca>, hereby add my Signed-off-by to this commit: c338c50 Signed-off-by: timbl-ont <tim.bloomfield@ontario.ca>
I, Tim Bloomfield <tim.bloomfield@ontario.ca>, hereby add my Signed-off-by to this commit: 6695030 Signed-off-by: Tim Bloomfield <tim.bloomfield@ontario.ca>
I, Tim Bloomfield <tim.bloomfield@gmail.com>, hereby add my Signed-off-by to this commit: 212c7b3 Signed-off-by: Tim Bloomfield <tim.bloomfield@gmail.com>
|
@jamshale thanks for the feedback. It is fixed now. I am switching between two github accounts and did not realize my DCO remediation PR was with a different github config from the initial PR. Anyway, fixed now after signing off on all the authors. |
|
Dang! there's just a linting issue now at This ones a bit annoying but it's the same in aca-py. |
Signed-off-by: timbl-ont <tim.bloomfield@ontario.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix on ./oid4vci/exchange-supported/records delete. There is a typo that duplicates the "credential supported identifier" as a parameter causing deletes to fail.
FYI @dbluhm