Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ACA-Py dependencies #49

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Update ACA-Py dependencies #49

merged 7 commits into from
Dec 5, 2023

Conversation

WadeBarnes
Copy link
Contributor

Resolves: #28

jamshale
jamshale reviewed Dec 4, 2023
View reviewed changes
redis_events/pyproject.toml
fastapi = "^0.68.0"
nest-asyncio = "^1.5.5"
pydantic = "^1.8.2"
python = "^3.9"
redis = "^4.1.4"
uvicorn = "0.16.0"

# Define ACA-Py as an optional/extra dependancy so it can be
# explicitly installed with the plugin if desired.
aries-cloudagent = { version = ">=0.10.3, < 1.0.0", optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My repo-manager script, which I think will become more important as this repo grows, works off of empty lines between sections. I don't think it would handle the comments very well either because it sorts.

But I can change the logic a bit to handle things like this better. I think this approach makes sense. We'll have to do this for the other plugins as well but can merge this for now and then do the rest if this is successful.

@jamshale
Copy link
Contributor

jamshale commented Dec 4, 2023

I think this will work good. I'll just add a couple reviewers to get some other eyes on it.

@jamshale jamshale requested review from esune and dbluhm December 4, 2023 17:22
@WadeBarnes WadeBarnes mentioned this pull request Dec 4, 2023
Merged
@WadeBarnes
Copy link
Contributor Author

WadeBarnes commented Dec 4, 2023 •
edited
Loading

The tests on the connection_update plugin are failing due to an expired certificate on https://indy.igrant.io/. Do we have contact info for the developers?

@WadeBarnes
Copy link
Contributor Author

The basicmessage_storage plugin is affected by the same issue.

@WadeBarnes
Update ACA-Py dependencies in the redis_events plugin
d503e74 
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes
Update ACA-Py dependencies for plugin_globals
ddcf4d0 
- Make it easier to spin up the dev container environment.

Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes
Update ACA-Py dependencies in the multitenant_provider plugin
67828fa 
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes
Update ACA-Py dependencies in the kafka_events plugin
1ca0b2d 
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes
Update ACA-Py dependencies in the connection_update plugin
518ff94 
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes
Update ACA-Py dependencies in the basicmessage_storage plugin
43e91af 
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes WadeBarnes force-pushed the aca-py-dep-management branch from 6466f99 to 43e91af Compare December 4, 2023 21:49
@WadeBarnes WadeBarnes marked this pull request as ready for review December 4, 2023 21:50
@WadeBarnes
Copy link
Contributor Author

Ready to go. Though we need to figure out what to do with the failing tests. We either need to get igrant.io to update the certificate or switch to a different ledger like http://test.bcovrin.vonx.io/. Open to suggestions.

@WadeBarnes
Switch to using BCovrin Test as the ledger for integration tests.
8d8a5db 
Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@swcurran
Copy link
Contributor

swcurran commented Dec 4, 2023

Agree that using BCovrin Test is the right thing to do for this.

@WadeBarnes
Copy link
Contributor Author

Switching to http://test.bcovrin.vonx.io/ fixed the issues with the failing integration tests.

@jamshale jamshale merged commit d430101 into openwallet-foundation:main Dec 5, 2023
3 checks passed
dbluhm pushed a commit to Indicio-tech/aries-acapy-plugins that referenced this pull request Dec 12, 2023
@WadeBarnes @dbluhm
Update ACA-Py dependencies (openwallet-foundation#49)
fa2c6f7 
* Update ACA-Py dependencies in the redis_events plugin

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

* Update ACA-Py dependencies for plugin_globals

- Make it easier to spin up the dev container environment.

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

* Update ACA-Py dependencies in the multitenant_provider plugin

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

* Update ACA-Py dependencies in the kafka_events plugin

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

* Update ACA-Py dependencies in the connection_update plugin

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

* Update ACA-Py dependencies in the basicmessage_storage plugin

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

* Switch to using BCovrin Test as the ledger for integration tests.

Signed-off-by: Wade Barnes <wade@neoterictech.ca>

---------

Signed-off-by: Wade Barnes <wade@neoterictech.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamshale jamshale jamshale left review comments

@dbluhm dbluhm dbluhm approved these changes

@esune esune Awaiting requested review from esune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plug-In dependency managament and version mismatch issues
4 participants
@WadeBarnes @jamshale @swcurran @dbluhm