Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating dependabot to support GHA, python, JS, TS, docker and dev container packages #494

Merged
merged 1 commit into from
May 22, 2024

Conversation

rajpalc7
Copy link
Contributor

No description provided.

… dev container packages

Signed-off-by: Rajpal Chauhan <rajpal.chauhan@gov.bc.ca>
@rajpalc7
Copy link
Contributor Author

Hi @WadeBarnes, this is ready for review now.

Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll leave the final review and approval to the regular maintainers.

@jamshale
Copy link
Contributor

I'm not sure if we want to manage adding another section to the dependabot config everytime. I didn't know it was like this already. Although the changes to weekly are good.

Is it possible just to have a single config for each type at the root directory?

@WadeBarnes
Copy link
Contributor

Unfortunately you have to point Dependabot at the folder containing the dependency manifests. It's not smart enough to search the folders to find the manifests.

@swcurran
Copy link
Contributor

Having instructions to update the dependabot config when adding a plugin is not a bad thing. We don't add them that often...

I assume that is the issue?

@jamshale
Copy link
Contributor

Having instructions to update the dependabot config when adding a plugin is not a bad thing. We don't add them that often...

I assume that is the issue?

Ya. Mostly just managing all the places. Some of the plugins have multiple places/configs nested inside them. For the simpler plugins it's only the root and integration test folder.

We can merge it though and see how it goes. Maybe figure something out in the future.

@jamshale jamshale merged commit e0074b7 into openwallet-foundation:main May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants