Fixes and interop testing #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
Against Credo and Sphereon libraries. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
force-pushed
the
fix/sphereon-interop
branch
from
d2e63af to
067a0a3
Compare
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
jamshale
reviewed
Jul 15, 2024
jamshale
approved these changes
Jul 15, 2024
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds interop testing against Credo and Sphereon's OID4VCI client library. There were also some fixes to achieve interop:
issandcredentialSubject.issuerfields using record Issuer ID instead of the verification method ID.Heads up @timbl-ont @weiiv, there might be some minor conflicts with the work you've been doing.