Fix outbound queue with webhook-url #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamshale
force-pushed
the
feat/82-redis-events-with-webhook-url
branch
from
5da47bf to
d69c50f
Compare
Signed-off-by: jamshale <jamiehalebc@gmail.com>
jamshale
force-pushed
the
feat/82-redis-events-with-webhook-url
branch
from
d69c50f to
40d88cd
Compare
jamshale
commented
Feb 2, 2024
| event.topic) | ||
| endpoint = f"{endpoint}/topic/{webhook_topic}/" | ||
| headers = {"x-wallet-id": wallet_id} if wallet_id else {} | ||
| if not api_key: |
There was a problem hiding this comment.
This was the main mistake... Not sure how it got missed.
dbluhm
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where an empty header value was added to the outbound payload which caused the outbound transit to fail. Also, ignore webhook forwarding for messages which don't match the webhook event map.
Added a available dummy server to the integration test network and enabled the webhook url config in the integration tests.
I still don't understand why pushing an invalid outbound message into the queue is actually blocking/breaking the queue from continuing to work. This is a problem, as this small one line mistake, caused the invalid payload. I'll be trying to figure out how to prevent this, but this is still a fix/improvement for the current problem.
@jpnortherblock