Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (backport): routing behind mediator #2537

Merged

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Oct 8, 2023

No description provided.

codespree and others added 4 commits October 7, 2023 20:05
Signed-off-by: Varun Chatterji <varun@seventhsense.ai>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm merged commit c5d16ed into openwallet-foundation:0.10.x Oct 8, 2023
6 checks passed
@dbluhm dbluhm deleted the fix/routing-keys-backport branch October 8, 2023 00:21
@swcurran
Copy link
Contributor

swcurran commented Oct 8, 2023

@codespree -- a "0.10.4-rc0" image has been created -- https://github.com/hyperledger/aries-cloudagent-python/pkgs/container/aries-cloudagent-python/135290717?tag=py3.9-0.10.4-rc0 -- are you able to give it a try?

@WadeBarnes -- if you can deploy this release in any BC Gov deployments, that would be great.

@@ -152,7 +163,7 @@ def didcomm_services_recip_keys_are_refs_routing_keys_are_did_key(
service["routingKeys"] = [
DIDKey.from_public_key_b58(key, ED25519).key_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without applying the transform in the first case, wouldn't it still be a key and not ref? As DIDKey.from_public_key_b58(key, ED25519).key_id would provide a did:key:.... not a ref. In which case, it would still fail to give DIDCommService at the pydid.deserialize_document() stage? @dbluhm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIDKey.key_id is a reference (perhaps not the best name for the property)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants