Anoncreds-rs pytest update #2541
Conversation
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
| @@ -198,7 +198,7 @@ async def register_schema( | |||
| if not profile.settings.get_value("wallet.type"): | |||
| # TODO is this warning necessary? | |||
| reason += ": missing wallet-type?" | |||
| raise AnonCredsRegistrationError(reason) | |||
| raise AnonCredsResolutionError(reason) | |||
There was a problem hiding this comment.
It seems like this really ought to be a registration error rather than a resolution error; the operation attempted is a register rather than a resolve so, even in the event we were attempting to resolve something in order to register something immediately after, I think it is better for this to be a registration error from an interface perspective.
There was a problem hiding this comment.
OK, sounds good. This was just inconsistent with other similar calls/logic.
There was a problem hiding this comment.
updated related code
aries_cloudagent/anoncreds/issuer.py
Outdated
| @@ -220,7 +222,7 @@ async def create_and_register_schema( | |||
| raise AnonCredsIssuerError( | |||
| "Schema already exists but was not in wallet; stored in wallet" | |||
| ) from err | |||
| except AnoncredsError as err: | |||
| except (AnoncredsError, BaseAnonCredsError, LedgerError) as err: | |||
There was a problem hiding this comment.
LedgerError will only be raised by Indy components; LedgerError should be wrapped into a BaseAnonCredsError subtype rather than be handled in this abstract/general interface.
There was a problem hiding this comment.
updated related code
aries_cloudagent/anoncreds/issuer.py
Outdated
| @@ -335,7 +337,7 @@ async def create_and_register_credential_definition( | |||
| CredDef.from_native(cred_def), | |||
| options, | |||
| ) | |||
| except AnoncredsError as err: | |||
| except (AnoncredsError, BaseAnonCredsError, LedgerError) as err: | |||
There was a problem hiding this comment.
updated related code.
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
usingtechnology
changed the title
…egacyIndyRegistry Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
|
Kudos, SonarCloud Quality Gate passed!
|
Updates to pytests that were affected by anoncreds-rs updates.
Since we have not updated/implemented endorser in the anoncreds-rs branch, I have left endorser related tests as skipped. These are now marked:
@pytest.mark.skip(reason="anoncreds-rs/endorser breaking change")closes #2433