Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 clarify LedgerError message when TAA is required and not accepted #2545

Merged
merged 1 commit into from
Oct 13, 2023
Merged

🎨 clarify LedgerError message when TAA is required and not accepted #2545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions aries_cloudagent/ledger/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ async def create_and_send_schema(
else:
if await self.is_ledger_read_only():
raise LedgerError(
"Error cannot write schema when ledger is in read only mode"
"Error cannot write schema when ledger is in read only mode, "
"or TAA is required and not accepted"
)

try:
Expand Down Expand Up @@ -497,7 +498,8 @@ async def create_and_send_credential_definition(

if await self.is_ledger_read_only():
raise LedgerError(
"Error cannot write cred def when ledger is in read only mode"
"Error cannot write cred def when ledger is in read only mode, "
"or TAA is required and not accepted"
)

cred_def_req = await self._create_credential_definition_request(
Expand Down
6 changes: 4 additions & 2 deletions aries_cloudagent/ledger/indy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,8 @@ async def update_endpoint_for_did(
if exist_endpoint_of_type != endpoint:
if await self.is_ledger_read_only():
raise LedgerError(
"Error cannot update endpoint when ledger is in read only mode"
"Error cannot update endpoint when ledger is in read only mode, "
"or TAA is required and not accepted"
)

nym = self.did_to_nym(did)
Expand Down Expand Up @@ -817,7 +818,8 @@ async def register_nym(
"""
if await self.is_ledger_read_only():
raise LedgerError(
"Error cannot register nym when ledger is in read only mode"
"Error cannot register nym when ledger is in read only mode, "
"or TAA is required and not accepted"
)

public_info = await self.get_wallet_public_did()
Expand Down