-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch PR 3391 - 0.11.lts #3395
Patch PR 3391 - 0.11.lts #3395
Conversation
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@ryjones can you help with this? See notes from @jamshale above. @WadeBarnes anything you can do? I’m guessing not, but figured I’d ask and make sure you knew about this. 🤞 |
I can help with the aries-cloudagent pypi project, but I'm unclear on what, exactly, needs to be done. |
@WadeBarnes I might need to change this workflow more. It's using an old username/password authentication that is no longer supported. In the https://pypi.org/project/aries-cloudagent/ account somewhere I thought it might be available for maintainers. I think I can change this workflow to the new way and give better instructions. |
We’re trying to publish LTS releases of ACA-Py — back when it was in Hyperledger. So we need to publish to the old PyPi project “aries-cloudagent” and the old Hyperledger GHCR. This is the first time we’ve had to do this. |
Yeah, I thought I saw some work going on to support trusted publishers. I think it would be better to update the workflow to support that and then we can register the publisher with the aries-cloudagent pypi project. |
@ryjones will need to assist with the PAT for that part. |
Signed-off-by: jamshale <jamiehalebc@gmail.com>
is there more for me to do here? |
If you've already setup an access token that will allow workflows in this project to publish images to the |
@WadeBarnes done |
|
I'm going to run all the tests manually on this branch and then I will try and make the release. |
@swcurran For pypi do we create a 0.11.4 release? I haven't understood what we do for the python package. The ghcr just replaces the previous image so that's straightforward. |
So.. I should have tested this better before. The problem doesn't actually affect 0.11.lts . Soft binding was introduced after. This version should be safe. All this work will be used for 0.12.lts patch though. I'm going to close this and move to that release. |
Thanks, Jamie. Good to know we don’t have to do 0.11. That’s helpful. |
For this to work someone with access to https://pypi.org/project/aries-cloudagent/ needs to set a new publisher.
Then we also need someone from hyperledger to set the new HYPERLEDGER_GHCR_PAT token in the openwallet-foundation repo. See https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic.