Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch PR 3391 - 0.11.lts #3395

Closed

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Dec 10, 2024

For this to work someone with access to https://pypi.org/project/aries-cloudagent/ needs to set a new publisher.

Then we also need someone from hyperledger to set the new HYPERLEDGER_GHCR_PAT token in the openwallet-foundation repo. See https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic.

secrets.HYPERLEDGER_GHCR_PAT

Signed-off-by: jamshale <jamiehalebc@gmail.com>
@swcurran
Copy link
Contributor

@ryjones can you help with this? See notes from @jamshale above.

@WadeBarnes anything you can do? I’m guessing not, but figured I’d ask and make sure you knew about this.

🤞

@jamshale jamshale changed the title Backport PR 3391 Patch PR 3391 - 0.11.lts Dec 10, 2024
@WadeBarnes
Copy link
Contributor

I can help with the aries-cloudagent pypi project, but I'm unclear on what, exactly, needs to be done.

@jamshale
Copy link
Contributor Author

jamshale commented Dec 10, 2024

@WadeBarnes I might need to change this workflow more. It's using an old username/password authentication that is no longer supported. In the https://pypi.org/project/aries-cloudagent/ account somewhere I thought it might be available for maintainers.

I think I can change this workflow to the new way and give better instructions.

@swcurran
Copy link
Contributor

We’re trying to publish LTS releases of ACA-Py — back when it was in Hyperledger. So we need to publish to the old PyPi project “aries-cloudagent” and the old Hyperledger GHCR. This is the first time we’ve had to do this.

@WadeBarnes
Copy link
Contributor

@WadeBarnes I might need to change this workflow more. It's using an old username/password authentication that is no longer supported. In the https://pypi.org/project/aries-cloudagent/ account somewhere I thought it might be available for maintainers.

I think I can change this workflow to the new way and give better instructions.

Yeah, I thought I saw some work going on to support trusted publishers. I think it would be better to update the workflow to support that and then we can register the publisher with the aries-cloudagent pypi project.

@WadeBarnes
Copy link
Contributor

and the old Hyperledger GHCR.

@ryjones will need to assist with the PAT for that part.

Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Copy link
Contributor Author

So this pypi part should be easier now. Someone just needs to add a new publisher with the openwallet information.

image

@WadeBarnes
Copy link
Contributor

WadeBarnes commented Dec 10, 2024

Done. Matched the existing one for hyperledger/aries-cloudagent-python.

image

@ryjones
Copy link
Contributor

ryjones commented Dec 11, 2024

is there more for me to do here?

@WadeBarnes
Copy link
Contributor

is there more for me to do here?

If you've already setup an access token that will allow workflows in this project to publish images to the ghcr.io/hyperledger/aries-cloudagent-python repo, then no.

@ryjones
Copy link
Contributor

ryjones commented Dec 12, 2024

@WadeBarnes done

@WadeBarnes
Copy link
Contributor

@WadeBarnes done

Thanks @ryjones. Back to you @jamshale

@jamshale
Copy link
Contributor Author

I'm going to run all the tests manually on this branch and then I will try and make the release.

@jamshale
Copy link
Contributor Author

@swcurran For pypi do we create a 0.11.4 release? I haven't understood what we do for the python package.

The ghcr just replaces the previous image so that's straightforward.

@jamshale
Copy link
Contributor Author

So.. I should have tested this better before. The problem doesn't actually affect 0.11.lts . Soft binding was introduced after. This version should be safe.

All this work will be used for 0.12.lts patch though. I'm going to close this and move to that release.

@jamshale jamshale closed this Dec 12, 2024
@swcurran
Copy link
Contributor

Thanks, Jamie. Good to know we don’t have to do 0.11. That’s helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants