Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch PR 3391 - 0.12.lts #3396

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Dec 10, 2024

We need someone from hyperledger to set the new HYPERLEDGER_GHCR_PAT token in the openwallet-foundation repo. See https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic

secrets.HYPERLEDGER_GHCR_PAT

Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale changed the title Backport PR 3391 Patch PR 3391 - 0.12.lts Dec 10, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Copy link
Contributor Author

All the tests passed for this patch, so I think we can go ahead.

@jamshale jamshale requested review from dbluhm and swcurran December 12, 2024 18:00
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamshale jamshale merged commit f358c1b into openwallet-foundation:0.12.lts Dec 12, 2024
4 checks passed
@jamshale
Copy link
Contributor Author

The image succeeded 🚀 https://github.com/orgs/hyperledger/packages/container/package/aries-cloudagent-python

I'm not sure what to do about the pypi package though. I think we could try creating a 0.12.3 release if required. Because the image is the preferred way to deploy acapy, maybe we can get away with just having the patched image?

Not really sure what happened with the package for previous patches...

@swcurran
Copy link
Contributor

I can create a new release on the 0.12 branch — is that the next step? That should publish the PyPi package, if the scripts work as expected, right? Let me know and I’ll create the PR.

@jamshale
Copy link
Contributor Author

jamshale commented Dec 12, 2024

I can create a new release on the 0.12 branch — is that the next step? That should publish the PyPi package, if the scripts work as expected, right? Let me know and I’ll create the PR.

Yes I believe so. It should use the updated pypi workflow on the 0.12.lts branch and the OICD auth that Wade set up.

@swcurran swcurran mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants