Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust coverage location for sonarcloud #3399

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jamshale
Copy link
Contributor

Ok. This should actually fix the sonar coverage reporting.

Github actions did change so that last PR was needed. However, the coverage report gets saved at the current location now. It no longer needs to be moved into a test-reports folder.

It actually probably didn't need to do this before. Just needed to move from the runner location to the workspace location. That's what changed.

Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale requested review from swcurran and ianco December 11, 2024 19:19
@jamshale jamshale requested a review from esune December 11, 2024 19:24
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll believe it when I see it :-) .

@swcurran swcurran merged commit 3f25d20 into openwallet-foundation:main Dec 11, 2024
11 checks passed
@jamshale
Copy link
Contributor Author

It worked 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants