Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up from Release 1.2.0 -- including LTS change #3432

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Jan 9, 2025

Update references to the previous release follow the new 1.2.0 Release.

Update the snyk configuration to use the 1.2.lts branch.

@jamshale -- take a look at the snyk config. For the 0.12.lts branch, there is no aries-agent path. Should we add the aries-cloudagent path that doesn't existin in main? I assume that is OK, since it has been working fine even though there is no aries-agent folder in the 0.12.lts branch.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
jamshale
jamshale previously approved these changes Jan 9, 2025
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 0.12.lts branch would need to scan it's aries_cloudagent/** path for the source code. I haven't looked at this before. Maybe we can just add it here. Not sure what happens when it scans a path that doesn't exist.

@swcurran swcurran requested review from a team January 9, 2025 17:03
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

swcurran commented Jan 9, 2025

I think it is safe to add it in, since the referenced folder is not in the 0.12.lts branch and it hasn't complained. Curious now to see if there are other things found now that we've added that...

@swcurran swcurran requested a review from jamshale January 9, 2025 17:05
Copy link

sonarqubecloud bot commented Jan 9, 2025

@swcurran swcurran merged commit 8eba663 into openwallet-foundation:main Jan 9, 2025
11 checks passed
sownak pushed a commit to cheqd/aries-cloudagent-python that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants