fix: 1993 assign satisfiedSubmissions to submissionEntry in getSubmissionRequirementRulePick
#1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DJHunn39
changed the title
getSubmissionRequirementRulePick
|
Could you sign of your comit? https://github.com/hyperledger/aries-rfcs/blob/main/contributing.md#signing-off-commits-dco |
Signed-off-by: DJHunn39 <danny.hunn@nearform.com>
DJHunn39
force-pushed
the
fix/1993-submissionEntry-for-pick-submissions
branch
from
b6d8770
to
500935a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1993
The PR adjusts
getSubmissionRequirementRulePickto assign allsatisfiedSubmissionstosubmissionEntry, rather thansubmission.This is a bug fix, but if anyone relies on the
submissionproperty, this could be seen as a breaking change.