[feature] Added openwisp_radius installation #223

atb00ker · 2020-11-21T17:00:15Z

Todo:

test celery-beat tasks
Check docs

Implements #198.

atb00ker

Started with openwisp_radius ansible setup. 😄

molecule/resources/converge.yml

tasks/apt.yml

tasks/freeradius.yml

templates/openwisp2/settings.py

nemesifier

Thanks for starting this Ajay, great progress, I left some comments, more review and testing will be needed but it's surely going well.

defaults/main.yml

templates/openwisp2/urls.py

atb00ker

~~@pandafy @nemesisdesign, please find the comments below, I think this out of the oven, a second pair eyes would be very helpful! 😄~~
New error found, working on it.

README.md

templates/openwisp2/urls.py

templates/openwisp2/settings.py

atb00ker · 2020-12-05T14:01:09Z

It fails on molecule but works on my system install.
Need to investigate.

atb00ker · 2020-12-08T20:19:17Z

@pandafy, stuck at #223 (comment), if you have time, please look into it.
It works only device but running on molecule fails, looks like a django / dependency related thing (might need to version lock something).

nemesifier · 2020-12-09T19:18:05Z

I wonder why we have a task that installs cryptography in this role, cryptography should be a dependency of django-x509 and I don't think we have to explicitly install it.

I am releasing a new minor version of django-x509 to ensure the cryptography dependency is bound: openwisp/django-x509#108
Then I will remove the pip install task from this role (#239).

pandafy · 2020-12-10T14:02:48Z

@atb00ker this is occurring becausue openwisp/openwisp-radius@0819e35 was added after version 0.1.0. This should not occur if you test with the latest master. I guess it will require issuing 0.2.0 release of openwisp-radius

atb00ker · 2020-12-10T14:57:02Z

@pandafy got it, since radius 2 release is so close, then let's wait for it! 😄

nemesifier · 2020-12-11T21:16:43Z

@pandafy got it, since radius 2 release is so close, then let's wait for it!

@atb00ker openwisp-radius 0.2 is out! 😁
https://github.com/openwisp/openwisp-radius/releases/tag/0.2.0

atb00ker · 2021-04-28T14:21:46Z

molecule/resources/verify.yml

@@ -64,3 +64,22 @@
        - name: Show OpenWisp log
          debug:
            var: openwisp_log
+
+    - name: Check Freeradius
+    # TODO: This test should work when openwisp-radius 0.3.0 is released!


This remains a blocker to merge this PR.
We would need to release the next version of openwisp-radius to enable testing here.

yes we're getting near to that 👍

nemesifier · 2021-04-28T22:45:56Z

tasks/freeradius.yml

+
+- name: Inner tunnel
+  template:
+    src: freeradius/openwisp_site.j2


@atb00ker isn't this wrong?

Yes, this was one of the causes of build failure,fixed it in the latest commit! 😄

nemesifier

This is basically ready!
OpenWISP RADIUS 0.3 milestone issues: https://github.com/openwisp/openwisp-radius/milestone/1

nemesifier

I found an issue that prevents the group configurations (radius group check, radius group reply) from working when using registration with phone number because the plus sign gets escaped. This is breaking group authorization rules.

To fix it we need to add a configurable variable called openwisp2_freeradius_safe_characters defaulting to +@abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789.-_: /.

Then in the configuration of the SQL dialect in use has to be changed, I think we have to replace the line which contains safe_characters =, because it seems the default is different depending on the DB:

https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/raddb/mods-config/sql/main/postgresql/queries.conf here the default is commented out
https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/raddb/mods-config/sql/main/mysql/queries.conf here it's not commented out

The value we put should be:

safe_characters = "{{ openwisp2_freeradius_safe_characters }}"

nemesifier · 2021-08-13T22:18:53Z

defaults/main.yml

+cron_delete_old_users: "'hour': 0, 'minute': 10"
+cron_cleanup_stale_radacct: "'hour': 0, 'minute': 20"
+cron_delete_old_postauth: "'hour': 0, 'minute': 30"
+cron_delete_old_radacct: "'hour': 1, 'minute': 30"


I think we should prefix these cron variables with openwisp2 for consistency, since it's configuration related to openwisp.

nemesifier · 2021-08-13T23:09:36Z

I found an issue that prevents the group configurations (radius group check, radius group reply) from working when using registration with phone number because the plus sign gets escaped. This is breaking group authorization rules.

Commit 8bebc28 should fix it. I tested it. WIll keep an eye on the CI.

nemesifier · 2021-09-24T20:12:10Z

I have merged this manually in the dev branch, I will keep this open until dev is ready to be recommended as a way to install OpenWISP RADIUS, something I'm working on with @pandafy.

nemesifier · 2021-10-08T23:04:05Z

Merged manually in the dev branch, this can be closed, thank you very much @atb00ker! 👍 👍

atb00ker · 2021-10-10T12:13:09Z

@nemesisdesign awesome, big win! 😄

atb00ker commented Nov 21, 2020

View reviewed changes

atb00ker force-pushed the openwisp_radius branch from 03428e0 to bec48bc Compare November 29, 2020 15:59

nemesifier reviewed Dec 1, 2020

View reviewed changes

defaults/main.yml Outdated Show resolved Hide resolved

defaults/main.yml Outdated Show resolved Hide resolved

defaults/main.yml Outdated Show resolved Hide resolved

templates/openwisp2/urls.py Outdated Show resolved Hide resolved

nemesifier mentioned this pull request Dec 4, 2020

[feature] Add API URLs by default #234

Closed

atb00ker force-pushed the openwisp_radius branch 3 times, most recently from 3e2dee8 to b898ca9 Compare December 5, 2020 10:21

atb00ker changed the title ~~{WIP}[feature] Added openwisp_radius installation~~ [feature] Added openwisp_radius installation Dec 5, 2020

atb00ker marked this pull request as ready for review December 5, 2020 10:35

atb00ker commented Dec 5, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

atb00ker requested a review from nemesifier December 5, 2020 10:42

atb00ker force-pushed the openwisp_radius branch from b898ca9 to 3a6e7c0 Compare December 5, 2020 11:54

atb00ker marked this pull request as draft December 5, 2020 12:17

atb00ker force-pushed the openwisp_radius branch from 3a6e7c0 to 5dfa2c6 Compare December 5, 2020 13:14

atb00ker commented Dec 5, 2020

View reviewed changes

templates/openwisp2/urls.py Outdated Show resolved Hide resolved

templates/openwisp2/settings.py Outdated Show resolved Hide resolved

atb00ker marked this pull request as ready for review December 5, 2020 13:17

atb00ker force-pushed the openwisp_radius branch 4 times, most recently from b615612 to 6193334 Compare December 5, 2020 13:50

nemesifier and others added 5 commits April 28, 2021 00:10

[change] Adjusted interval of cron tasks

9c6ff64

[chores] Allow disabling openwisp_radius.tasks.delete_old_radacct

3b035c5

[chores] Added more notes to variables

1255daf

[openwisp-radius] Add test to ensure freeradius is working

6680a18

[chores] Added basic inner-tunnel

ef14796

atb00ker commented Apr 28, 2021

View reviewed changes

atb00ker force-pushed the openwisp_radius branch 4 times, most recently from 77a25a9 to 301e123 Compare April 28, 2021 16:53

[freeradius] Fixed problems prohibiting start

8c0bbc8

atb00ker force-pushed the openwisp_radius branch from 301e123 to 8c0bbc8 Compare April 28, 2021 18:29

nemesifier reviewed Apr 28, 2021

View reviewed changes

nemesifier reviewed Apr 30, 2021

View reviewed changes

Merge branch 'master' into openwisp_radius

9ab2950

nemesifier reviewed Aug 12, 2021

View reviewed changes

Merge branch 'master' into openwisp_radius

cd2eb08

nemesifier reviewed Aug 13, 2021

View reviewed changes

[fix] Added safe_characters to freeradius SQL conf

8bebc28

nemesifier force-pushed the openwisp_radius branch from f50a1b9 to 8bebc28 Compare August 13, 2021 23:07

nemesifier added 2 commits September 17, 2021 18:11

Merge branch 'master' into openwisp_radius

2b717b1

Merge branch 'master' into openwisp_radius

88c9acc

nemesifier closed this Oct 8, 2021

nemesifier deleted the openwisp_radius branch October 18, 2022 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Added openwisp_radius installation #223

[feature] Added openwisp_radius installation #223

atb00ker commented Nov 21, 2020 •

edited

Loading

atb00ker left a comment

nemesifier left a comment

atb00ker left a comment •

edited

Loading

atb00ker commented Dec 5, 2020 •

edited

Loading

atb00ker commented Dec 8, 2020 •

edited

Loading

nemesifier commented Dec 9, 2020 •

edited

Loading

pandafy commented Dec 10, 2020 •

edited

Loading

atb00ker commented Dec 10, 2020

nemesifier commented Dec 11, 2020

atb00ker Apr 28, 2021

nemesifier Apr 28, 2021

nemesifier Apr 28, 2021

atb00ker Apr 29, 2021

nemesifier left a comment

nemesifier left a comment •

edited

Loading

nemesifier Aug 13, 2021

nemesifier commented Aug 13, 2021

nemesifier commented Sep 24, 2021

nemesifier commented Oct 8, 2021

atb00ker commented Oct 10, 2021

[feature] Added openwisp_radius installation #223

[feature] Added openwisp_radius installation #223

Conversation

atb00ker commented Nov 21, 2020 • edited Loading

atb00ker left a comment

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

atb00ker left a comment • edited Loading

Choose a reason for hiding this comment

atb00ker commented Dec 5, 2020 • edited Loading

atb00ker commented Dec 8, 2020 • edited Loading

nemesifier commented Dec 9, 2020 • edited Loading

pandafy commented Dec 10, 2020 • edited Loading

atb00ker commented Dec 10, 2020

nemesifier commented Dec 11, 2020

atb00ker Apr 28, 2021

Choose a reason for hiding this comment

nemesifier Apr 28, 2021

Choose a reason for hiding this comment

nemesifier Apr 28, 2021

Choose a reason for hiding this comment

atb00ker Apr 29, 2021

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

nemesifier left a comment • edited Loading

Choose a reason for hiding this comment

nemesifier Aug 13, 2021

Choose a reason for hiding this comment

nemesifier commented Aug 13, 2021

nemesifier commented Sep 24, 2021

nemesifier commented Oct 8, 2021

atb00ker commented Oct 10, 2021

atb00ker commented Nov 21, 2020 •

edited

Loading

atb00ker left a comment •

edited

Loading

atb00ker commented Dec 5, 2020 •

edited

Loading

atb00ker commented Dec 8, 2020 •

edited

Loading

nemesifier commented Dec 9, 2020 •

edited

Loading

pandafy commented Dec 10, 2020 •

edited

Loading

nemesifier left a comment •

edited

Loading