Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Separate version to avoid circular import #510

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

nemesifier
Copy link
Member

This patch allows importing the version from settings.py without suffering exceptions which are caused by circular imports.

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • N/A I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • N/A I have updated the documentation.

This patch allows importing the version from settings.py
without suffering exceptions which are caused by circular
imports.
@nemesifier nemesifier added the bug label Dec 27, 2024
@nemesifier nemesifier self-assigned this Dec 27, 2024
Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nemesifier nemesifier merged commit 65f2497 into master Dec 27, 2024
6 checks passed
@nemesifier nemesifier deleted the separate-version branch December 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants