Fix : django-filter looks for 'filterset_class' attribute now #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Oct 30, 2023
… into gbip-fix_tests
gbip
dismissed
nemesifier’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
tests.django_restframework_gis_tests.test_filters.TestRestFrameworkGisFilters.test_GeometryField_filteringwas failing. After checking my database logs, it seemed that postgres was not receiving the right query, as the where clause was missing.I looked a bit into the django-filter setup and it needed an update.
The fix was to rename the attribute
filter_classtofilterset_class, as per the doc.