separate job for QA tests

[3nids]

No description provided.

[auvipy]

I think that would be a logical move

[3nids]

coverage is missing, should it simply be added to requirements-unit-test.txt, or should it come from openwisp-utils[qa]?

[auvipy]

may be should be added to requirements-unit-test.txt

[nemesifier]

Thank you @3nids! I understand where this comes from and I agree we should not stop the build if QA checks fail.

However, separating the jobs implies installing the python packages twice, increasing build time and energy consumption unnecessarily.

I found a different solution which I am rolling out in other modules I maintain in the OpenWISP organization: openwisp/openwisp-controller@5fff20c
Summary of the solution:

• Install all dependencies in one step
• Run QA checks as usual
• Run tests always except if the build was cancelled or if the install dependencies step failed, this allows to run tests also if QA checks failed
• Run coveralls only if all previous steps succeded

I think we should adopt the same approach, unless you have a good argument against this approach or a better alternative.

[3nids]

This sound great!