Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] FreeRADIUS PostAuthView returns 500 error #467

Open
pandafy opened this issue Jan 11, 2023 · 8 comments · May be fixed by #513
Open

[bug] FreeRADIUS PostAuthView returns 500 error #467

pandafy opened this issue Jan 11, 2023 · 8 comments · May be fixed by #513
Labels
bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Easy issues for attracting Hacktoberfest participants.

Comments

@pandafy
Copy link
Member

pandafy commented Jan 11, 2023

The FreeRADIUS PostAuthView (/api/v1/freeradius/postauth/) returns HTTP 500 error if the length of called_station_id field exceeds 50 characters.

A possible fix could be to update the PostAuthSerializer and set max_length attribute on the called_station_id field. This way, the view would return HTTP 400 with the error reason.
@pandafy pandafy added the bug Something isn't working label Jan 11, 2023
@ujjwalkirti
Copy link
Contributor

@pandafy I want to work on this issue, can you assign this issue to me?

@pandafy
Copy link
Member Author

pandafy commented Aug 16, 2023

@ujjwalkirti you can start working on this issue. You don't need to wait for someone to assign this issue to you, just an intent message is enough. 😄

I would recommend you to start by writing a failing test case before updating the serializer.

I would also recommend you to join the OpenWISP development chat.

@pandafy pandafy added good-first-issue Good for newcomers Hacktoberfest Easy issues for attracting Hacktoberfest participants. labels Aug 16, 2023
@nick2432
Copy link

can i start working on this?

@pandafy
Copy link
Member Author

pandafy commented Dec 20, 2023 •
edited
Loading

Yes @nick2432, go ahead! Don't forget to read my previous comments.

@samirgorai samirgorai mentioned this issue Jan 28, 2024
Closed
@samirgorai
Copy link

#509

Shiva953 added a commit to Shiva953/openwisp-radius that referenced this issue Feb 18, 2024
@Shiva953
[fix] Fixed FreeRADIUS PostAuthView returning 500 error openwisp#467
0ce90bf 
Set the max_length attribute to be equal to 50 on the called_station_id
field, so that it doesn't give a 500 error(400 error instead) every time
it exceeds 50.

Fixes openwisp#467
@Shiva953 Shiva953 linked a pull request Feb 18, 2024 that will close this issue
Open
Shiva953 added a commit to Shiva953/openwisp-radius that referenced this issue Feb 22, 2024
@Shiva953
[fix] Fixed failing QA check openwisp#467
db05e03 
The QA check was failing earlier because the latest commit wasn't
following the conventional commit guidelines, this commit fixes it. Ran
both the openwisp-qa-format and openwisp-qa-check commands.

Fixes openwisp#467
@sumiran18
Copy link

I want to work on this issue , can you pls assign me this ?

@nemesifier
Copy link
Member

Welcome @sumiran18! Create a PR first, then I'll assign it to you.

@sanjeevholla26
Copy link

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good-first-issue Good for newcomers Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
OpenWISP Contributor's Board
Status: To do (Python & Django)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Fixed FreeRADIUS PostAuthView returning 500 error Shiva953/openwisp-radius
7 participants
@nemesifier @samirgorai @pandafy @ujjwalkirti @nick2432 @sanjeevholla26 @sumiran18