for issue #507 and issue #467 #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her raises server error #507 added exception handler Signed-off-by: Samir Gorai <samirgorai17@gmail.com>
in RadiusPostAuthSerializer() serializer variable "called_station_id" attribute max_length to 50 Signed-off-by: Samir Gorai <samirgorai17@gmail.com>
This was referenced Jan 28, 2024
Closed
pandafy
requested changes
Jan 29, 2024
There was a problem hiding this comment.
@samirgorai kindly read OpenWISP's contribution docs before opening a PR. The commit message and code formatting do not follow OpenWISP's guidelines.
I recommend you to open separate PRs for each issue and add unit tests for the fixes.
|
@pandafy thanks for the advice |
|
@pandafy can you help me how can i perform action as mentioned in Documentation 1. Python code conventions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #507 and issue #467