[feature] Added view to collect email in SAML registration #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pandafy
force-pushed
the
saml-intermediate-view
branch
4 times, most recently
from
d5426db
to
cbaef31
Compare
pandafy
force-pushed
the
saml-intermediate-view
branch
4 times, most recently
from
4a7897f
to
6f84147
Compare
If the IdP does not include email address in SAML response, then the user will be asked for email during sign-up.
pandafy
force-pushed
the
saml-intermediate-view
branch
from
6f84147
to
3d3b7a5
Compare
nemesifier
reviewed
Nov 7, 2024
| @@ -26,6 +26,11 @@ def get_saml_urls(saml_views=None): | |||
| saml_views.AssertionConsumerServiceView.as_view(), | |||
| name='saml2_acs', | |||
| ), | |||
| path( | |||
| 'additional-info/', | |||
| saml_views.LoginAdditionalInfoView.as_view(), | |||
There was a problem hiding this comment.
I don't love the naming here, if we are asking only for the email here, why are we calling everything "additional info"?
I think we should call this view LoginCollectEmailView, the URL collect-email/ and the template collect-email.html.
What do you think?
There was a problem hiding this comment.
I used a generic name in-case we used this view to ask for additional information. E.g., we could ask the user to verify the name received from the IdP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Description of Changes
If the IdP does not include email address in SAML response, then the user will be asked for email during sign-up.