buildworker: start: fix broken non TLS setups #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in commit 3812ff7 ("buildworker: start: fix worker startup failure after update") broke non TLS setups. So lets fix it by setting SSL: only if BUILDWORKER_TLS is set. Fixes: 3812ff7 ("buildworker: start: fix worker startup failure after update") Reported-by: Paul Spooren <mail@aparcar.org> Signed-off-by: Petr Štetiar <ynezz@true.cz>
ynezz
referenced
this pull request
Oct 24, 2024
Workers are currently refusing to work:
Unhandled Error
Traceback (most recent call last):
File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 673, in run
runApp(config)
File "/opt/venv/lib/python3.11/site-packages/twisted/scripts/twistd.py", line 29, in runApp
runner.run()
File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 370, in run
self.application = self.createOrGetApplication()
File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 437, in createOrGetApplication
application = getApplication(self.config, passphrase)
--- <exception caught here> ---
File "/opt/venv/lib/python3.11/site-packages/twisted/application/app.py", line 446, in getApplication
application = service.loadApplication(filename, style, passphrase)
File "/opt/venv/lib/python3.11/site-packages/twisted/application/service.py", line 404, in loadApplication
application = sob.loadValueFromFile(filename, "application")
File "/opt/venv/lib/python3.11/site-packages/twisted/persisted/sob.py", line 174, in loadValueFromFile
codeObj = compile(data, filename, "exec")
builtins.SyntaxError: keyword argument repeated: connection_string (buildbot.tac, line 49)
as the buildbot.tac template changed in commit 4ba1dcb66155 ("worker:
Add option --connection-string for create-worker") and in version v3.10.0.
So lets use this new `--connection-string` feature and get rid of the
sed-fu.
Fixes: efbddc9 ("Bump buildbot to v3.11.1 release")
Signed-off-by: Petr Štetiar <ynezz@true.cz>
|
My initial test was to remove SSL too but it caused the worker to fail. I think using connection string implies using encryption. The solution for me was to actually drop the connection string entirely, worked well |
Without it, errors may appear: WARNING: Makefile 'package/feeds/telephony/freeswitch/Makefile' has a dependency on 'libpcre', which does not exist make[2]: Entering directory '/builder/shared-workdir/build/scripts/config' make[2]: 'conf' is up to date. make[2]: Leaving directory '/builder/shared-workdir/build/scripts/config' Checking 'python3-pyelftools'... failed. Checking 'python3-dev'... ok. Checking 'python3-setuptools'... ok. Checking 'swig'... ok. u-boot: Please install the Python3 elftools module Fixes: 3ac7d39 ("buildworker,buildmaster: bump Debian to version 12") Signed-off-by: Paul Spooren <mail@aparcar.org>
aparcar
reviewed
Oct 25, 2024
Signed-off-by: Paul Spooren <mail@aparcar.org>
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in commit 3812ff7 ("buildworker: start: fix worker startup failure after update") broke non TLS setups. So lets fix it by setting SSL: only if BUILDWORKER_TLS is set.
Fixes: 3812ff7 ("buildworker: start: fix worker startup failure after update")
Reported-by: Paul Spooren mail@aparcar.org