Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-status: Move "Scroll to tail" button to header line on syslog and kernellog status pages #7002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CharlesMengCA
Copy link

@CharlesMengCA CharlesMengCA commented Mar 20, 2024

Layout after the changes.

Button

@systemcrash
Copy link
Contributor

Hello! Thank you for this PR.

Would you like to move the button for aesthetic reasons? Balance?

I think I will NACK this for a few reasons:

  • for the majority L-to-R readers it's an extra eye-scan to read the button content from the header text.
  • You now have to move the mouse quite far - some extra mileage, especially when you might actually need to swap between the kernel and system logs. More exercise than necessary :)

@CharlesMengCA
Copy link
Author

Just look at the github headers, you will see it is very common to put the header and buttons on the same row.

Capture

This way will save some space on vertical direction. Normally most of monitors are 4:3, 16:9 or even wider, the vertical space is kind of tight and shouldn't be wasted.

Most the time, when I am on the log page, I will use the mouse wheel to scroll down the log to see if there is an error or warning.

Moving the button away will give me more view area at the beginning.

@Ramon00
Copy link
Contributor

Ramon00 commented Mar 31, 2024

  • You now have to move the mouse quite far - some extra mileage, especially when you might actually need to swap between the kernel and system logs. More exercise than necessary :)

I also like the current layout, indeed, if i need to skip between kernel and syslog then i dont need move my mouse too much.

Most the time, when I am on the log page, I will use the mouse wheel to scroll down the log to see if there is an error or warning.

Moving the button away will give me more view area at the beginning.

That kind of kills the argument about the viewing space, you can just use the scroll wheel to move the button off the screen.

@CharlesMengCA
Copy link
Author

CharlesMengCA commented Apr 4, 2024

Moved button beside the header.

Just don't like two separated lines for a short header and a single button.

Button

@systemcrash
Copy link
Contributor

@Ramon00 - updated. Good?

@Ramon00
Copy link
Contributor

Ramon00 commented Apr 9, 2024

@systemcrash I think its a good compromise!

@CharlesMengCA CharlesMengCA force-pushed the ScrollTobuttons branch 2 times, most recently from 4d61445 to cdf1dac Compare April 16, 2024 00:18
@CharlesMengCA
Copy link
Author

What's next? just waiting for the approval? :)

@CharlesMengCA CharlesMengCA force-pushed the ScrollTobuttons branch 2 times, most recently from fe76350 to 5771508 Compare April 26, 2024 01:52
@CharlesMengCA CharlesMengCA force-pushed the ScrollTobuttons branch 3 times, most recently from 4d36274 to 6c7e611 Compare May 23, 2024 18:52
…g and kernellog status pages

Signed-off-by: CharlesMengCA <CharlesMeng@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants