-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-mod-status: Move "Scroll to tail" button to header line on syslog and kernellog status pages #7002
base: master
Are you sure you want to change the base?
Conversation
Hello! Thank you for this PR. Would you like to move the button for aesthetic reasons? Balance? I think I will NACK this for a few reasons:
|
Just look at the github headers, you will see it is very common to put the header and buttons on the same row. This way will save some space on vertical direction. Normally most of monitors are 4:3, 16:9 or even wider, the vertical space is kind of tight and shouldn't be wasted. Most the time, when I am on the log page, I will use the mouse wheel to scroll down the log to see if there is an error or warning. Moving the button away will give me more view area at the beginning. |
I also like the current layout, indeed, if i need to skip between kernel and syslog then i dont need move my mouse too much.
That kind of kills the argument about the viewing space, you can just use the scroll wheel to move the button off the screen. |
eec9dc6
to
80684a2
Compare
80684a2
to
6e20d5f
Compare
@Ramon00 - updated. Good? |
@systemcrash I think its a good compromise! |
4d61445
to
cdf1dac
Compare
What's next? just waiting for the approval? :) |
fe76350
to
5771508
Compare
5771508
to
b553b40
Compare
b553b40
to
0cb3780
Compare
4d36274
to
6c7e611
Compare
6c7e611
to
46c516f
Compare
46c516f
to
11246a7
Compare
…g and kernellog status pages Signed-off-by: CharlesMengCA <CharlesMeng@outlook.com>
11246a7
to
5ec1eda
Compare
Layout after the changes.