luci-mod-rdash: add new package #7431

tp82d1 · 2024-11-29T13:11:04Z

Description

This PR adds a new package, luci-mod-rdash, which provides an interactive dashboard for routers.

Key features:

Dynamic icons for internet status, device information and connected clients.
Real-time system information display, including CPU usage and connected devices number.

stangri · 2024-11-29T17:36:19Z

Not sure if you'd want to change things again, but with the dashes in luci-mod-info, the underscore in info_dashboard looks out of place and might facilitate typing errors when typing the package name.

tp82d1 · 2024-11-29T19:05:54Z

Updated the package name from luci-mod-info_dashboard to luci-mod-info-dashboard for consistency as suggested.

Ansuel · 2024-11-29T19:39:15Z

screenshot of this?

systemcrash · 2024-11-29T19:46:35Z

@Ansuel

See previous attempt at #7424

screenshot of this?

tp82d1 · 2024-11-29T19:49:25Z

@Ansuel

Screenshots

Dashboard

Internet Status When Connected

Internet Status When Not Connected

Device Information

Connected Clients

modules/luci-mod-info-dashboard/Makefile

modules/luci-mod-info-dashboard/htdocs/luci-static/resources/view/info-dashboard/css/custom.css

...s/luci-mod-info-dashboard/htdocs/luci-static/resources/view/info-dashboard/include/d_dhcp.js

modules/luci-mod-info-dashboard/htdocs/luci-static/resources/view/info-dashboard/index.js

systemcrash · 2024-11-30T14:07:02Z

Consider naming your dashboard something creative. Name it after yourself if you want. "info" is waaaaay too generic and may clash with namespaces eventually that shall be used by openwrt itself.

tp82d1 · 2024-11-30T17:59:35Z

Renamed package to luci-mod-rdash for clarity and namespace safety.
Replaced minified files with readable versions as requested.
Cleaned up commit history and removed PKG_VERSION/PKG_RELEASE fields.

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/index.js

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/include/d_devices.js

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/css/custom.css

systemcrash · 2024-11-30T18:12:02Z

squash commits please

This commit includes: - Adding the new package. - Renaming the package and replacing old files. - Adding an extra line at the end of files. Signed-off-by: Rick Clark <tplink.82d1@proton.me>

tp82d1 · 2024-11-30T21:03:27Z

Changes made as requested:

Added an extra line at the end of the files.
Squashed commits into one commit.

systemcrash · 2024-11-30T21:06:51Z

Revise your commit message to simply "introduce new luci-mod-rdash dashboard" or something so people don't go looking for any "changes".

Any comments from @dannil or @stangri or @stokito ?

systemcrash · 2024-11-30T21:09:18Z

One question: how does everything look in dark mode? Those black line diagrams on a dark background might look interesting. :)

dannil · 2024-11-30T21:15:03Z

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/include/d_dhcp.js

This file is using tab indentation instead of space as the rest of your JS files, you may want to align all the files.

Well spotted. Yes please, use tab indentation.

systemcrash · 2024-11-30T22:50:14Z

One question: how does everything look in dark mode? Those black line diagrams on a dark background might look interesting. :)

Take a look at how I did it in dfd802a (if your css does not already handle that).

stokito · 2024-11-30T22:52:08Z

modules/luci-mod-rdash/Makefile

+	# No configure step needed
+endef
+
+define Build/Compile


Can we remove the section? As far I remember you may want to declare the empty section to override i.e. remove the default compile step. Please try to run the build without it

stokito · 2024-11-30T22:52:41Z

modules/luci-mod-rdash/Makefile

+	# No compile step needed
+endef
+
+define Package/luci-mod-rdash/install


The Luci build system will do all the steps itself. No need to declare them here.

stokito · 2024-11-30T22:53:35Z

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/css/custom.css

@@ -0,0 +1,300 @@
+.dashboard-container {


the cascade.css has variable with standard colors that you may want to use here

stokito · 2024-11-30T23:44:32Z

tp82d1#1

stokito · 2024-11-30T23:46:43Z

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/include/d_devices.js

+        var mem = L.isObject(memoryinfo.memory) ? memoryinfo.memory : {};
+        var totalMemory = mem.total || 0;
+        var usedMemory = (mem.total && mem.free) ? (mem.total - mem.free) : 0;
+        var availableMemory = mem.free || 0;


the var is unused

stokito · 2024-11-30T23:47:56Z

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/include/d_devices.js

+    expect: { result: [] }
+});
+
+var MountSkipList = [


the list is unused

stokito · 2024-11-30T23:48:34Z

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/include/d_devices.js

+        var boardinfo = data[0],
+            systeminfo = data[1],
+            memoryinfo = data[2],
+            mounts = data[3],


the var is unused

tp82d1 · 2024-12-01T01:08:22Z

Thanks all for the reviews. To be honest, I didn't think it would require lots of these steps (it's my first time). The goal of this project was about "getting everything in one place, just like the default firmware of a TP-Link router dashboard." So I took some parts of "10_system.js, 20_memory.js, 30_network.js, and 40_dhcp.js" and some parts of other packages, such as Luci-mod-dashboard and Luci-app-cpu-status, to combine them in one package. Im not experts in coding, so I wrote the code with ChatGPT's help. Finally, I will try to fix what you mentioned; if I can't, I'll shutdown the project. In the meantime, I'll change the pull to draft.

hnyman · 2024-12-01T09:06:06Z

If this gets merged, I hope that you're committing to maintain this in compatible status for several years.

(We have been burned with enthusiastic creation of some theme or dashboard, and then soon after that the creator loses interest, and the app starts rotting when there are changes in the surrounding OpenWrt. )

jow- · 2024-12-04T14:07:10Z

modules/luci-mod-rdash/root/usr/share/rpcd/acl.d/luci-mod-rdash.json

+		"description": "Grant access to the system route status",
+		"read": {
+			"ubus": {
+				"file": [ "exec" ]


This exec permissions does not appear to be required, please drop it.

jow- · 2024-12-04T14:08:23Z

modules/luci-mod-rdash/root/usr/share/rpcd/acl.d/luci-mod-rdash.json

+				"luci": [ "getVersion" ],
+				"file": [ "list", "read" ],
+				"system": [ "board", "info" ],
+				"network.rrdns": [ "lookup" ]


There does not appear to be any reverse lookup calls in this code, so please drop this permission.

jow- · 2024-12-04T14:09:43Z

modules/luci-mod-rdash/root/usr/share/rpcd/acl.d/luci-mod-rdash.json

+				"/www/luci-static/resources/view/status/include": [ "list" ],
+				"/etc/board.json": [ "read" ],
+				"/proc/sys/net/netfilter/nf_conntrack_count": [ "read" ],
+				"/proc/sys/net/netfilter/nf_conntrack_max": [ "read" ]


The simplified dashboard code does not appear to read any of those files, drop the read permissions for them.

jow- · 2024-12-04T14:10:14Z

modules/luci-mod-rdash/root/usr/share/rpcd/acl.d/luci-mod-rdash.json

+			},
+			"ubus": {
+				"luci": [ "getVersion" ],
+				"file": [ "list", "read" ],


There does not appear to be any filesystem listing calls, drop the list permission

jow- · 2024-12-04T14:11:10Z

modules/luci-mod-rdash/root/usr/share/rpcd/acl.d/luci-mod-rdash.json

+				"/proc/sys/net/netfilter/nf_conntrack_max": [ "read" ]
+			},
+			"ubus": {
+				"luci": [ "getVersion" ],


This appears unused

tp82d1 changed the title ~~luci-mod-info_dashboard: add new package~~ luci-mod-info-dashboard: add new package Nov 29, 2024

tp82d1 force-pushed the add-info-dashboard-package branch from 39f8783 to 04e494a Compare November 29, 2024 19:02

tp82d1 force-pushed the add-info-dashboard-package branch from 04e494a to cc72d2b Compare November 30, 2024 07:59

systemcrash reviewed Nov 30, 2024

View reviewed changes

modules/luci-mod-info-dashboard/Makefile Outdated Show resolved Hide resolved

systemcrash reviewed Nov 30, 2024

View reviewed changes

modules/luci-mod-info-dashboard/htdocs/luci-static/resources/view/info-dashboard/css/custom.css Outdated Show resolved Hide resolved

systemcrash reviewed Nov 30, 2024

View reviewed changes

...s/luci-mod-info-dashboard/htdocs/luci-static/resources/view/info-dashboard/include/d_dhcp.js Outdated Show resolved Hide resolved

systemcrash reviewed Nov 30, 2024

View reviewed changes

modules/luci-mod-info-dashboard/htdocs/luci-static/resources/view/info-dashboard/index.js Outdated Show resolved Hide resolved

systemcrash marked this pull request as draft November 30, 2024 14:07

tp82d1 force-pushed the add-info-dashboard-package branch 2 times, most recently from 84f6a85 to 21da814 Compare November 30, 2024 17:52

tp82d1 changed the title ~~luci-mod-info-dashboard: add new package~~ luci-mod-rdash: add new package Nov 30, 2024

tp82d1 force-pushed the add-info-dashboard-package branch from 21da814 to b612532 Compare November 30, 2024 17:58

tp82d1 marked this pull request as ready for review November 30, 2024 17:59

systemcrash reviewed Nov 30, 2024

View reviewed changes

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/index.js Outdated Show resolved Hide resolved

systemcrash reviewed Nov 30, 2024

View reviewed changes

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/include/d_devices.js Show resolved Hide resolved

systemcrash reviewed Nov 30, 2024

View reviewed changes

modules/luci-mod-rdash/htdocs/luci-static/resources/view/rdash/css/custom.css Show resolved Hide resolved

tp82d1 force-pushed the add-info-dashboard-package branch 2 times, most recently from 42fcd2d to 6d0ce68 Compare November 30, 2024 20:58

luci-mod-rdash: add new package with fixes

e9e3667

This commit includes: - Adding the new package. - Renaming the package and replacing old files. - Adding an extra line at the end of files. Signed-off-by: Rick Clark <tplink.82d1@proton.me>

tp82d1 force-pushed the add-info-dashboard-package branch from 6d0ce68 to e9e3667 Compare November 30, 2024 21:00

dannil suggested changes Nov 30, 2024

View reviewed changes

stokito approved these changes Nov 30, 2024

View reviewed changes

tp82d1 marked this pull request as draft December 1, 2024 01:08

jow- reviewed Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

luci-mod-rdash: add new package #7431

luci-mod-rdash: add new package #7431

tp82d1 commented Nov 29, 2024 •

edited

Loading

stangri commented Nov 29, 2024

tp82d1 commented Nov 29, 2024

Ansuel commented Nov 29, 2024

systemcrash commented Nov 29, 2024

tp82d1 commented Nov 29, 2024 •

edited

Loading

systemcrash commented Nov 30, 2024

tp82d1 commented Nov 30, 2024

systemcrash commented Nov 30, 2024

tp82d1 commented Nov 30, 2024

systemcrash commented Nov 30, 2024

systemcrash commented Nov 30, 2024

dannil Nov 30, 2024 •

edited

Loading

systemcrash Nov 30, 2024

systemcrash commented Nov 30, 2024

stokito Nov 30, 2024

stokito Nov 30, 2024

stokito Nov 30, 2024

stokito commented Nov 30, 2024

stokito Nov 30, 2024

stokito Nov 30, 2024

stokito Nov 30, 2024

tp82d1 commented Dec 1, 2024

hnyman commented Dec 1, 2024

jow- Dec 4, 2024

jow- Dec 4, 2024

jow- Dec 4, 2024

jow- Dec 4, 2024

jow- Dec 4, 2024

luci-mod-rdash: add new package #7431

Are you sure you want to change the base?

luci-mod-rdash: add new package #7431

Conversation

tp82d1 commented Nov 29, 2024 • edited Loading

Description

stangri commented Nov 29, 2024

tp82d1 commented Nov 29, 2024

Ansuel commented Nov 29, 2024

systemcrash commented Nov 29, 2024

tp82d1 commented Nov 29, 2024 • edited Loading

Screenshots

Dashboard

Internet Status When Connected

Internet Status When Not Connected

Device Information

Connected Clients

systemcrash commented Nov 30, 2024

tp82d1 commented Nov 30, 2024

systemcrash commented Nov 30, 2024

tp82d1 commented Nov 30, 2024

systemcrash commented Nov 30, 2024

systemcrash commented Nov 30, 2024

dannil Nov 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

systemcrash commented Nov 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stokito commented Nov 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tp82d1 commented Dec 1, 2024

hnyman commented Dec 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tp82d1 commented Nov 29, 2024 •

edited

Loading

tp82d1 commented Nov 29, 2024 •

edited

Loading

dannil Nov 30, 2024 •

edited

Loading