Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-upnp: Add Expires to port map listing #7481

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Self-Hosting-Group
Copy link

Status/overview UI:

openwrt-status-overview
Screenshot 23.05 release

The Port Control Protocol (PCP) is the successor to NAT-PMP, has similar protocol concepts and packet formats, but adds support for IPv6 port maps and options/extensions. For more information, see:
Port Mapping Protocols Overview and Comparison 2024: About UPnP IGD & PCP/NAT-PMP
https://github.com/Self-Hosting-Group/wiki/wiki/Port-Mapping-Protocols-Overview

Maintainer: @jow-

Previous improvement: #7407

Close openwrt#7481

Signed-off-by: Self-Hosting-Group <selfhostinggroup-git+openwrt@shost.ing>
@Self-Hosting-Group
Copy link
Author

Draft, as the cell should have a text-align: right to display correctly, the following CSS would still need to be inserted, or can the alignment be set via the LuCI API?

#upnp_status_table th:nth-child(6),
#upnp_status_table td:nth-child(6) {
	text-align: right;
}

The time calculation is done on the client, the backend would probably be more accurate.

I chose expires because it is clear, short and should be easy to translate. However, another term could be used, the following come to mind:

Port map ...

  • valid until
  • expiration
  • time left
  • duration
  • lifetime
  • expires
  • expiry
  • valid

Could be a nice thing for the 24.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant