luci-mod-status: add simple filtering for connections #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemcrash
reviewed
Dec 23, 2024
modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
Outdated
Show resolved
Hide resolved
McGiverGim
force-pushed
the
add_connections_filter
branch
from
17391e1 to
311ce29
Compare
|
I replaced the text with the samples (but I'm ready to change it if someone prefers a better wording) and added comparison with ignore case to protocol and network. |
systemcrash
reviewed
Dec 24, 2024
modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
Outdated
Show resolved
Hide resolved
systemcrash
reviewed
Dec 24, 2024
modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
Outdated
Show resolved
Hide resolved
systemcrash
reviewed
Dec 24, 2024
modules/luci-mod-status/htdocs/luci-static/resources/view/status/connections.js
Show resolved
Hide resolved
|
Is it really needed? |
|
It’s low effort, and high value when dealing with lots of endpoints, so it’s a welcome addition I think. @McGiverGim also thinks so. |
|
ok, just newer thought that someone may need to search or even filter by the ip |
|
I think it's useful when you want to see the connections from a host, for example. If this is not needed, then the full list of connections it's not needed neither, because now it's a big list but you can't find anything because it's big and changes continuosly. |
McGiverGim
force-pushed
the
add_connections_filter
branch
2 times, most recently
from
0d640a5 to
3482725
Compare
This commit adds a simple filtering input text into the connections status page. You can type some filtering like: - '100.15' -> Will show only connections that include this '100.15' onto the IP. - 'UDP 100.15' -> Will show only UDP connections that include this '100.15' onto the IP. - ':443' -> Will show only connections that use the port 443 as source or destination. You can use a part of the IP or part of the name if the DNS resolution button is enabled. It's a very simple filter that can grow in the future if it deserves some interest, maybe adding some regular expression support. Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
McGiverGim
force-pushed
the
add_connections_filter
branch
from
3482725 to
88edae4
Compare
|
Took it for a spin. Works fine. |
|
Thanks @McGiverGim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple filtering input text into the connections status page. You can type some filtering like:
You can use a part of the IP or part of the name if the DNS resolution button is enabled.
It's a very simple filter that can grow in the future if it deserves some interest, maybe adding some regular expression support.