Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-filemanager: Use read_direct to retrieve the file content #7505

Closed
wants to merge 0 commits into from

Conversation

rdmitry0911
Copy link
Contributor

@rdmitry0911 rdmitry0911 commented Dec 25, 2024

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile
  • Tested on: x86/64, openwrt-23.05, Chrome, Firefox βœ…
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo

Description: Use read_direct() to read the file that allows downloading and editing binary files

@systemcrash
Copy link
Contributor

A couple of points for next version: If it's a big 'hex only' file, perhaps disable the 'Toggle ASCII' button. There's no point in generating an error there when we click it if we won't open in ASCII. Maybe that can even go into this fix.

@rdmitry0911
Copy link
Contributor Author

disable the 'Toggle ASCII' button

I made some mess in this PR and finally closed it and opened a new one Your logic is correct and I put it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants