luci-app-acme: DNS API store all params

[stokito]

Fix #7504

[systemcrash]

This, in its present form, does not fix the bug. The data race is still present.

Test:

CF Key: 1
Save
Edit entry again. CF Key empty. Credentials empty.

[systemcrash]

When handling credentials, you’ll need to pull apart the variable and value, to determine whether an incoming variable already exists, and if so, replace it.

[stokito]

The _parseKeyValueListToMap() does this

[systemcrash]

Not quite. It checks to see whether an identical k+v exist in the set at add time, but not whether an identical k already exists with a different v. Such a check is necessary if a user changes their credentials for a provider.

[stokito]

it splits the K=V

let parts = paramKeyVal.split('=');
let name = parts[0];
let val = parts[1];

And saves to a map map.set(name, unquotedVal);

Then when any field was changed, we get the creds values credentialsDynList.getValue(), convert to a map, update the map :

if (newVal) {
	credsMap.set(optName, newVal);
} else {
	credsMap.delete(optName);
}

And and put the updated list back to the credentialsDynList:

credentialsDynList.setValue(newCreds);

[stokito]

Please merge it, I made another PR on top of the branch.

[systemcrash]

Merged. Good work!