-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-snmp: add SNMPv3 options and logging #25178
Conversation
09b46e5
to
e389392
Compare
Please make this optional. Enabling this unconditionally would result in my images being too large for my APs with 16MiB flash. |
Also, I would not remove that deprecated setting just like that. Maybe make the init script very verbose about it being deprecated and removed in X time. Both in stdout and using logger. People might be using it, and possibly breaking existing configs without any warning is something I really cannot tolerate. |
I will look into your suggestions on Monday. I understand your point with the port topic and I can undo that. Thank you for the review! |
You could have a look at the lldp package for inspiration - it has optional snmp support. |
e389392
to
37aa304
Compare
@stintel : I am still in the process of making this optional. In this other contribution I am preparing, I need openssl for SNMPv3. I have now three options:
Which one of these three options do you, as the maintainer, prefer? |
8f8a77d
to
f00cb28
Compare
f00cb28
to
64a848b
Compare
4d967f5
to
7993a4e
Compare
3a71f50
to
2319948
Compare
2319948
to
a7e2c09
Compare
Actually I was thinking about it the other day. At some point I made miniupnpd-iptables and miniupnpd-nftables variants (7fbc5d4). That sounds like a good solution here indeed. I would avoid using tiny and full variants, instead, I'd go for -ssl and -nossl variants, like mosquitto. |
Thank you for your input. I will work further in that direction. |
This commit integrates the option to add openssl to net-snmp. This way SNMP V3 can be modified Signed-off-by: Christian Korber <ckorber@tdt.de>
a7e2c09
to
77fef50
Compare
This commit implements SNMPv3 functionality to snmpd.init. In particular it adds function snmpd_snmpdv3_add, which sets the needed options in /var/run/snmpd.conf. Additionally a possibility to download mib file is also added. Signed-off-by: Christian Korber <ckorber@tdt.de>
This commit adds logging to syslog and to a logfile. Signed-off-by: Christian Korber <ckorber@tdt.de>
77fef50
to
0e61393
Compare
Maintainer: @stintel
Compile tested: x86_64, Openwrt 23.05
Run tested: x86_64, Openwrt 23.05
Description:
Openssl is needed to implement encryption and authentification for SNMPv3,
therefore the Makefile is modified for that purpose.
Also snmpV3 prerequisites are added to snmpd.init file and the possibility
to log messages to syslog or a log file.
At last the deprecated option to specifiy a port at
snmpd_trap_hostname_add()
and
snmpd_trap_ip_add()
is removed.