-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. #18825
Conversation
…eir broadcasts in the epilogues. Imported from GitHub PR #18825 Copybara import of the project: -- 2c9840f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18825 from openxla:gemm_fusion_effective_parameters 2c9840f PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 2c9840fb8e499db7510b7847cc12c45e6c2eeaee by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18825 from openxla:gemm_fusion_effective_parameters 2c9840fb8e499db7510b7847cc12c45e6c2eeaee PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR #18825 Copybara import of the project: -- 2c9840f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18825 from openxla:gemm_fusion_effective_parameters 2c9840f PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 2c9840fb8e499db7510b7847cc12c45e6c2eeaee by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18825 from openxla:gemm_fusion_effective_parameters 2c9840fb8e499db7510b7847cc12c45e6c2eeaee PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR #18825 Copybara import of the project: -- 2c9840f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18825 from openxla:gemm_fusion_effective_parameters 2c9840f PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 2c9840fb8e499db7510b7847cc12c45e6c2eeaee by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18825 from openxla:gemm_fusion_effective_parameters 2c9840fb8e499db7510b7847cc12c45e6c2eeaee PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR #18825 Copybara import of the project: -- 2c9840f by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18825 from openxla:gemm_fusion_effective_parameters 2c9840f PiperOrigin-RevId: 691406714
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 2c9840fb8e499db7510b7847cc12c45e6c2eeaee by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18825 from openxla:gemm_fusion_effective_parameters 2c9840fb8e499db7510b7847cc12c45e6c2eeaee PiperOrigin-RevId: 691406714
gemm_fusion_autotuner fails in a few tests F1030 15:35:52.295284 614 gemm_fusion_autotuner.cc:1041] Non-OK-status: has_executable.status() |
Which ones? gemm_fusion_autotuner_test and xla/service/gpu/fusions/triton/... pass. |
it is an internal test |
I didn't guess yet what's the reason. Could you share the HLO of the failing fusion? Or maybe just its epilogue without shapes? |
The HLO has |
2c9840f
to
37dc0d2
Compare
#19112 was merged, hopefully the problem you've seen got resolved. Please try to test / submit this one again. |
…sts in the epilogues.
…eir broadcasts in the epilogues. Imported from GitHub PR #18825 Copybara import of the project: -- 37dc0d2 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18825 from openxla:gemm_fusion_effective_parameters 37dc0d2 PiperOrigin-RevId: 696815211
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 37dc0d2f706bf681b1eff2088eb8d1000abf79b8 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18825 from openxla:gemm_fusion_effective_parameters 37dc0d2f706bf681b1eff2088eb8d1000abf79b8 PiperOrigin-RevId: 696815211
…eir broadcasts in the epilogues. Imported from GitHub PR #18825 Copybara import of the project: -- 37dc0d2 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18825 from openxla:gemm_fusion_effective_parameters 37dc0d2 PiperOrigin-RevId: 696815211
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 37dc0d2f706bf681b1eff2088eb8d1000abf79b8 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18825 from openxla:gemm_fusion_effective_parameters 37dc0d2f706bf681b1eff2088eb8d1000abf79b8 PiperOrigin-RevId: 696815211
…eir broadcasts in the epilogues. Imported from GitHub PR openxla/xla#18825 Copybara import of the project: -- 37dc0d2f706bf681b1eff2088eb8d1000abf79b8 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] GEMM fusions: let fusing effective parameters and their broadcasts in the epilogues. Merging this change closes #18825 PiperOrigin-RevId: 696963468
No description provided.